OSC: Don't do reverse name lookup when handling packets #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when using a listener/handler with the osc-server. Turns out, due to my being on a non-internet connected network,
INetAddress
was trying to perform a reverse name lookup on the server that had sent me the OSC packet. This was then hanging until the timeout was reached.Using
#getHostString
will not perform a lookup, and instead just use the hostname/ip the address was initialized with.I realize that this isn't (technically) a backwards compatible change, so let me know if I should add a flag to choose between the types of behavior.