Cast timeout-ms/wait-time to long #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where Clojure fails to resolves the Thread/sleep call on newer JVMs. Closes #497
Closed
plexus
added a commit
that referenced
this pull request
Dec 26, 2023
This is the first version without the internal SuperCollider server (libscsynth). See [this mailing list post](https://groups.google.com/g/overtone/c/qndjDV5FS9Y/m/lPo4QFYpAAAJ) for the reasoning behind that change. This also means we could drop the bulk of our dependencies, making Overtone much lighter. Our work continues to keep Overtone relevant for years to come. We've fixed a bunch of other long standing issues large and small, modernized the release tooling, and improved and added many docstrings. Since Linux users in particular face a rather confusing audio landscape, we've added a [Linux Audio Primer](https://github.com/overtone/overtone/wiki/Linux-Audio-Primer) to the wiki, to help you get situated. ## Changed - Remove embedded (internal) SuperCollider server - Provide clearer output about what it's doing when starting an external `scsynth` - Remove `project.clj`, switch to full Clojure CLI based tooling (see `bin/proj`) - Use `at-at` from Clojars, rather than inlining it here - Detect PipeWire only systems, and prefix `scynth` with `pw-jack`, if it's available ## Added - Add Karl Thorssens sampled trumpet instrument (`overtone.inst.sampled-trumpet`) - Added `set-fret` and `slide-string` to `overtone.synth.stringed` (#287) - Added `freesound-sample-pack`, for downloading a whole pack at once - Add an example file for the stringed synths (#287) - Add an alias `lin-env` for `lin`, for backwards compatibility - On the generated docstring for ugens that collide with Clojure built-ins, mention that you can add a final `:force-ugen` argument as a hint to treat it as a ugen (#505) - Store Freesound token in between sessions (#506) ## Fixed - Fix an issue where Clojure fails to resolve the right `Thread/sleep` implementation on newer JVMs (#502) - Fix calling synths/instruments with 21 arguments or more (#504) - Fix the namespace `overtone.inst.synth` on Clojure 1.11 (#505) - Mark `abs` as a Clojure numerical function, to make sure it is treated as a UGen when its arguments are not numerical (#505) - Make `synth`/`defsynth` and `inst`/`definst` take the same form of params (fixes regression, and makes `synth`/`inst` more useful) - Ignore errors in `jack_lsp`. Wayland based systems often don't have this command, in which case people can connect SuperCollider to their audio device manually, we should not fail for that. - Handle a 429 "too many requests" from Freesound more gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Clojure fails to resolves the Thread/sleep call on newer JVMs.
Closes #497