Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make symfony/console 3.2.0 minimal requirement #44

Merged
merged 1 commit into from Apr 29, 2018
Merged

Make symfony/console 3.2.0 minimal requirement #44

merged 1 commit into from Apr 29, 2018

Conversation

tuupola
Copy link
Contributor

@tuupola tuupola commented Apr 29, 2018

The Symfony\Component\Console\Terminal class is not available before 3.2.0. This breaks the builds using --prefer-lowest switch. This can also be tested locally from phplint source tree with:

$ composer update --prefer-lowest
$ bin/phplint

 PHP Fatal error:  Uncaught Error: Class 'Symfony\Component\Console\Terminal' not found in /xxx/phplint/src/Command/LintCommand.php:249

Setting to symfony/console minimum requirement to ^3.2 seems to fix the problem.

The Symfony\Component\Console\Terminal class is not available before 3.2.0.
@overtrue overtrue merged commit 74d13c1 into overtrue:master Apr 29, 2018
@overtrue
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants