Bug fix on process callback #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2021 10:02
…setting up property as Closure and then creating Closure from callable in the setter. Using short function syntax for the no-op function placeholder
|
Thanks, please resolve the conflicts. |
|
done |
|
Thanks. |
|
np thanks for quick merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process callback property is can be accessed before intialisation which causes a fatal error
This PR fixes that. It is also much better typed by using a
Closureinstead ofmixed, and it sets the property as nullable with null as default.Finally I changed the no -op function to a short syntax just because its a lot nicer :)