Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running 0.12.87 with --genpoi #1271

Closed
Bobcat00 opened this issue Jan 18, 2016 · 14 comments
Closed

Error running 0.12.87 with --genpoi #1271

Bobcat00 opened this issue Jan 18, 2016 · 14 comments

Comments

@Bobcat00
Copy link

Windows 8.1 64-bit overviewer-0.12.87.zip gets the following error with --genpoi:

C:\Users\Bob\Documents\Overviewer>overviewer.exe --config=worlds/config.py --genpoi --skip-scan
2016-01-17 21:29:25  Loaded UUID cache from 'C:\\users\\bob\\documents\\overviewer\\maps\\uuidcache.dat' with 0 entries
2016-01-17 21:29:26  Done handling POIs
2016-01-17 21:29:26  Writing out javascript files
2016-01-17 21:29:26  Wrote UUID cache with 0 entries
2016-01-17 21:29:26 E An error has occurred. This may be a bug. Please let us know!
See http://docs.overviewer.org/en/latest/index.html#help

This is the error that occurred:
Traceback (most recent call last):
  File "overviewer.py", line 605, in <module>
  File "overviewer.py", line 130, in main
  File "overviewer_core\aux_files\genPOI.pyc", line 533, in main
  File "overviewer_core\aux_files\genPOI.pyc", line 241, in save_cache
  File "overviewer_core\files.pyc", line 164, in __exit__
WindowsError: [Error 32] The process cannot access the file because it is being used by another process

The following is the output with version 0.12.82:

C:\Users\Bob\Documents\Overviewer>overviewer.exe --config=worlds/config.py --genpoi --skip-scan
2016-01-17 21:32:15  Loaded UUID cache from 'C:\\users\\bob\\documents\\overview
er\\maps\\uuidcache.dat' with 0 entries
2016-01-17 21:32:16  Done handling POIs
2016-01-17 21:32:16  Writing out javascript files
2016-01-17 21:32:16  Wrote UUID cache with 0 entries
2016-01-17 21:32:16  Done
@eminence
Copy link
Member

Perhaps another instance of overviewer is running? Something is holding open the yuid cache file

@Bobcat00
Copy link
Author

Definitely only one instance running. And I immediately reverted to 0.12.82 and re-ran Overviewer in the same command window with no problems. .82 to .87 involved changing the cache processing, so maybe that's where the problem lies.

CounterPillow added a commit that referenced this issue Jan 30, 2016
Previously, the files were not closed after reading or writing;
by using a "with" statement, the file handles will be closed as
soon as they go out of scope.

Possible fix for #1271.
@CounterPillow
Copy link
Member

I just pushed a change which may fix this, let us know if the problem still persists.

Thanks for your bug report.

@Bobcat00
Copy link
Author

Sorry for the bad news, but running Win 64-bit 12.90 gets the following error. (EDIT: This error is different than the original error).

C:\Users\Bob\Documents\Overviewer>overviewer.exe --config=worlds/config.py --genpoi --skip-scan
2016-01-30 16:12:15  Loaded UUID cache from 'C:\\users\\bob\\documents\\overviewer\\maps\\uuidcache.dat' with 0 entries
2016-01-30 16:12:16  Done handling POIs
2016-01-30 16:12:16  Writing out javascript files
2016-01-30 16:12:17  Wrote UUID cache with 0 entries
2016-01-30 16:12:17 E An error has occurred. This may be a bug. Please let us know!
See http://docs.overviewer.org/en/latest/index.html#help

This is the error that occurred:
Traceback (most recent call last):
  File "overviewer.py", line 605, in <module>
  File "overviewer.py", line 130, in main
  File "overviewer_core\aux_files\genPOI.pyc", line 535, in main
  File "overviewer_core\aux_files\genPOI.pyc", line 243, in save_cache
  File "overviewer_core\files.pyc", line 164, in __exit__
WindowsError: [Error 183] Cannot create a file when that file already exists

@halfsight5000
Copy link

Oh, here it is. I am getting this same script.
Windows 7 x64

OverViewer 0.12.93

Minecraft 1.9

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.

C:\Users\Shi>cd c:\Users\Shi\Desktop\overviewer

c:\Users\Shi\Desktop\overviewer>overviewer.exe --config=C:/Users/Shi/Desktop/ove
rviewer/config2.py --genpoi
2016-03-02 15:09:54 W Sorry, you requested dimension 'nether' for the render 're
nder9', but I couldn't find it
2016-03-02 15:09:54 Looking for entities in
2016-03-02 15:10:14 Done.
2016-03-02 15:10:14 Loaded UUID cache from 'M:\minecraft.weenmebrown.com\uuid
cache.dat' with 4 entries
2016-03-02 15:10:15 Done handling POIs
2016-03-02 15:10:15 Writing out javascript files
2016-03-02 15:10:15 Wrote UUID cache with 5 entries
2016-03-02 15:10:15 E An error has occurred. This may be a bug. Please let us kn
ow!
See http://docs.overviewer.org/en/latest/index.html#help

This is the error that occurred:
Traceback (most recent call last):
File "overviewer.py", line 605, in
File "overviewer.py", line 130, in main
File "overviewer_core\aux_files\genPOI.pyc", line 536, in main
File "overviewer_core\aux_files\genPOI.pyc", line 244, in save_cache
File "overviewer_core\files.pyc", line 164, in exit
WindowsError: [Error 183] Cannot create a file when that file already exists

c:\Users\Shi\Desktop\overviewer>

@matrixhacker
Copy link
Contributor

I was having this problem as well. I resolved it by renaming uuidcache.dat. Unfortunately the file must be renamed/removed before each run or the error will still occur.

@CounterPillow
Copy link
Member

It appears to be an issue with how Windows does atomic file renames, I'll try to look into it soon™.

@CounterPillow CounterPillow self-assigned this Apr 23, 2016
@calebsander
Copy link
Contributor

Still an issue in version 0.12.137.

@LeadMagnet
Copy link

I had the same problem on my server. IIS had changed the file permissions of several files to not allow overwrite. Since I didn't want to check hundreds of files, I deleted the entire output folder content and re-rendered the map. Solved my problem and subsequent passes.

@CounterPillow
Copy link
Member

@LeadMagnet I'm fairly sure this is a different issue though, related to atomic file renames, and nothing to do with permissions.

@JRSofty
Copy link

JRSofty commented Aug 26, 2016

With the [Error 183] can we get the name of the file/files that are causing the error, maybe we can delete them manually.

@calebsander
Copy link
Contributor

It happens whenever you try to rename a file to another file which already exists, on Windows.

@CounterPillow
Copy link
Member

The fix I just pushed should work, but since we currently don't have automatic Windows builds and I'm not feeling like getting my dev env set up on Windows again, I can't confirm that it works right now. If someone on Windows can build from git and show that it's still broken, I'll re-open.

@CounterPillow
Copy link
Member

@eminence hooked me up with an up-to-date Windows build from the not-yet-finished new build infrastructure and I can confirm that this bug is indeed fixed now. Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants