feat(api): validate yml plugin before import it (#5378)

* feat(api): validate yml plugin before import it close #5329 Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
ovh · Aug 18, 2020 · 6beace0 · 6beace0
1 parent 7cf81cc
commit 6beace0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/engine/api/grpc_plugin.go b/engine/api/grpc_plugin.go
@@ -26,6 +26,9 @@ func (api *API) postGRPCluginHandler() service.Handler {
 		if err := service.UnmarshalBody(r, &p); err != nil {
 			return sdk.WithStack(err)
 		}
+		if err := p.Validate(); err != nil {
+			return sdk.WithStack(err)
+		}
 		p.Binaries = nil
 
 		tx, err := db.Begin()
@@ -103,6 +106,9 @@ func (api *API) putGRPCluginHandler() service.Handler {
 		if err := service.UnmarshalBody(r, &p); err != nil {
 			return sdk.WithStack(err)
 		}
+		if err := p.Validate(); err != nil {
+			return sdk.WithStack(err)
+		}
 
 		var name = mux.Vars(r)["name"]
 		old, err := plugin.LoadByName(api.mustDB(), name)

diff --git a/sdk/plugin.go b/sdk/plugin.go
@@ -19,6 +19,13 @@ type GRPCPlugin struct {
 	Integration        string             `json:"integration" db:"-" yaml:"integration" cli:"integration"`
 }
 
+func (p *GRPCPlugin) Validate() error {
+	if p.Name == "" || p.Type == "" || p.Author == "" || p.Description == "" {
+		return NewErrorFrom(ErrPluginInvalid, "Invalid plugin: name, type, author and description are mandatory")
+	}
+	return nil
+}
+
 // GetBinary returns the binary for a specific os and arch
 func (p GRPCPlugin) GetBinary(os, arch string) *GRPCPluginBinary {
 	for _, b := range p.Binaries {