fix(api): allow description in application import and cli (#6344)

* fix(api): allow description in application import and cli * fix: remove description from cli
ovh · Oct 21, 2022 · d8168ff · d8168ff
1 parent 0bc7a67
commit d8168ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/engine/api/application/application_parser.go b/engine/api/application/application_parser.go
@@ -66,6 +66,7 @@ func ParseAndImport(ctx context.Context, db gorpmapper.SqlExecutorWithTx, cache
 	//Craft the application
 	app := new(sdk.Application)
 	app.Name = eapp.Name
+	app.Description = eapp.Description
 	app.VCSServer = eapp.VCSServer
 	app.RepositoryFullname = eapp.RepositoryName
 	app.FromRepository = opts.FromRepository

diff --git a/engine/api/application_import_test.go b/engine/api/application_import_test.go
@@ -37,6 +37,7 @@ func Test_postApplicationImportHandler_NewAppFromYAMLWithoutSecret(t *testing.T)
 
 	body := `version: v1.0
 name: myNewApp
+description: myDescription
 variables:
   var1:
     value: value 1
@@ -63,8 +64,9 @@ variables:
 	app, err := application.LoadByName(context.TODO(), db, proj.Key, "myNewApp", application.LoadOptions.WithVariables)
 	require.NoError(t, err)
 
-	assert.NotNil(t, app)
-	assert.Equal(t, "myNewApp", app.Name)
+	require.NotNil(t, app)
+	require.Equal(t, "myNewApp", app.Name)
+	require.Equal(t, "myDescription", app.Description)
 
 	//Check variables
 	for _, v := range app.Variables {