Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin/plugin-clair): vendor clairctl #3294

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Sep 6, 2018

No description provided.

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
p := usr.HomeDir + "/.clairctl"

if _, err := os.Stat(p); os.IsNotExist(err) {
os.Mkdir(p, 0700)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of os.Mkdir is not checked

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"github.com/spf13/viper"
)

var errNoInterfaceProvided = errors.New("could not load configuration: no interface provided")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errNoInterfaceProvided is unused

)

var errNoInterfaceProvided = errors.New("could not load configuration: no interface provided")
var errInvalidInterface = errors.New("Interface does not exist")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errInvalidInterface is unused

return viper.GetString("clairctl.tempFolder")
}

func values() config {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values is unused

Password string
}

type loginMapping map[string]Login

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loginMapping is unused

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
InsecureRegistries []string
}

type config struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config is unused

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault merged commit 84bc027 into master Sep 6, 2018
@yesnault yesnault deleted the ye-clair-plugin branch September 20, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants