-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dedicated): add slaac option to vrack ipv6 block #11663
feat(dedicated): add slaac option to vrack ipv6 block #11663
Conversation
ref: MANAGER-13715 Signed-off-by: mhalheli soufien <mhalheli.soufien@gmail.com>
data-ng-bind="::bridged.bridgedSubrange" | ||
></span> | ||
<span | ||
>SLAAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SLAAC is not in a constants file?
@@ -21,7 +21,33 @@ export default class VrackAssignedIpCtrl { | |||
} | |||
|
|||
$onInit() { | |||
this.refreshData(); | |||
this.vrackAssignedIpv6Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should bridgedSubranges be instead in the resolve of the routing file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop because this component is not loaded at the init of the page doing like this allow to make the call only when we open the ipv6 detail
&__sub-item { | ||
display: flex; | ||
justify-content: end; | ||
flex-flow: wrap; | ||
} | ||
|
||
&__subnet { | ||
&__subnet, | ||
&__subrang { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&__subrang { | |
&__subrange { |
@@ -8,14 +8,61 @@ | |||
<span data-translate="vrack__assigned-ipv6_add_subnet"></span> | |||
</button> | |||
</div> | |||
<!-- subridg --> | |||
<li | |||
class="vrack__assigned-ipv6__subrang" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class="vrack__assigned-ipv6__subrang" | |
class="vrack__assigned-ipv6__subrange" |
data-ng-bind="::bridged.bridgedSubrange" | ||
></span> | ||
<span | ||
>SLAAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>SLAAC | |
>$ctrl.label.SLAAC |
Put this in constant file
<oui-switch | ||
data-ng-hide="bridged.loading" | ||
model="bridged.model" | ||
on-change="$ctrl.toggleSubrang(bridged)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on-change="$ctrl.toggleSubrang(bridged)" | |
on-change="$ctrl.toggleSubrange(bridged)" |
></button> | ||
<script | ||
type="text/ng-template" | ||
id="vrack__assigned-ipv6__subrang_slaac_help.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id="vrack__assigned-ipv6__subrang_slaac_help.html" | |
id="vrack__assigned-ipv6__subrange_slaac_help.html" |
id="vrack__assigned-ipv6__subrang_slaac_help.html" | ||
> | ||
<p | ||
data-translate="vrack__assigned-ipv6__subrang_slaac_help" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-translate="vrack__assigned-ipv6__subrang_slaac_help" | |
data-translate="vrack_assigned_ipv6_subrange_slaac_help" |
@@ -61,6 +90,34 @@ export default class VrackAssignedIpCtrl { | |||
}; | |||
} | |||
|
|||
toggleSubrang(bridgedSubrange) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toggleSubrang(bridgedSubrange) { | |
toggleSubrange(bridgedSubrange) { |
data-ng-repeat="bridged in $ctrl.bridgedSubranges track by $index" | ||
> | ||
<span | ||
class="vrack__assigned-ipv6__subrang__title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class="vrack__assigned-ipv6__subrang__title" | |
class="vrack__assigned-ipv6__subrange__title" |
<a | ||
class="oui-link_icon" | ||
aria-hidden="true" | ||
data-ng-href="{{$ctrl.localZoneUrl}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the good URL ?
> | ||
<span class="oui-icon oui-icon-book ml-0" aria-hidden="true"></span> | ||
<span | ||
data-translate="vrack__assigned-ipv6__subrang_slaac_help_tooltip_link" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-translate="vrack__assigned-ipv6__subrang_slaac_help_tooltip_link" | |
data-translate="vrack_assigned_ipv6_subrange_slaac_help_tooltip_link" |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
1f1a214
into
feat/additional-ipv6-feature
feat/additional-ipv6-feature
Only FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related