-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regions_attributes #198
regions_attributes #198
Conversation
b3c0e1a
to
c9518dc
Compare
This looks good, you need to resolve the conflict though |
@yanndegat, customers needs this kind of edit to use their vrack with their k8s cluster using Terraform |
c9518dc
to
76896e4
Compare
rebased, and the conflicts went away 👍 |
As far as suitability, we've used this fork/change to deploy a cluster in prod |
@Kafei59 @yanndegat do you think we could get this in now? |
thanks a lot for this improvement. Could you just add a deprecated metadata for the regions/regions_status attributes. thanks again |
@yanndegat I think the deprecated metadata is added now, hopefully 👍 |
e45c3f0
to
c24e3a0
Compare
ok thanks a log, lgtm |
The openstackId attribute of a private network is useful, among other things, to setup a kube cluster in that private network. cf https://dl.plik.ovh/file/lc9J4dqIITkRBVhL/mhppqw02G1gENR7d/vrackbetafinalstage-allexceptmanager.pdf
This PR exposes the attributes of the private network resource through a
regions_attributes
field. I've successfully deployed a kubernetes cluster in a private network using that provider, like this:regions_attributes
expose all the regions of the private network, so a multi-region thing would do something else than[0]
, of course