Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regions_attributes #198

Merged
merged 2 commits into from
Oct 22, 2021
Merged

regions_attributes #198

merged 2 commits into from
Oct 22, 2021

Conversation

rienafairefr
Copy link
Contributor

@rienafairefr rienafairefr commented May 17, 2021

The openstackId attribute of a private network is useful, among other things, to setup a kube cluster in that private network. cf https://dl.plik.ovh/file/lc9J4dqIITkRBVhL/mhppqw02G1gENR7d/vrackbetafinalstage-allexceptmanager.pdf
This PR exposes the attributes of the private network resource through a regions_attributes field. I've successfully deployed a kubernetes cluster in a private network using that provider, like this:

resource "ovh_cloud_project_kube" "cluster-prod" {
  service_name = var.ovh_project
  name         = "kube-cluster
  region       = var.ovh_region
  version      = "1.20"
  private_network_id = ovh_cloud_project_network_private.network.regions_attributes.0.openstackid
}

regions_attributes expose all the regions of the private network, so a multi-region thing would do something else than [0], of course

@ricoleabricot
Copy link

This looks good, you need to resolve the conflict though

@ricoleabricot
Copy link

@yanndegat, customers needs this kind of edit to use their vrack with their k8s cluster using Terraform
Is this MR looks good for you (without mentioning the conflict) ?

@rienafairefr
Copy link
Contributor Author

rebased, and the conflicts went away 👍

@rienafairefr
Copy link
Contributor Author

As far as suitability, we've used this fork/change to deploy a cluster in prod

@loeken
Copy link

loeken commented Oct 15, 2021

@Kafei59 @yanndegat do you think we could get this in now?

@yanndegat
Copy link
Collaborator

hi @rienafairefr

thanks a lot for this improvement. Could you just add a deprecated metadata for the regions/regions_status attributes.
because imho the regions_attributes should eventually replace the "regions" one in a future release.

thanks again

@rienafairefr
Copy link
Contributor Author

@yanndegat I think the deprecated metadata is added now, hopefully 👍

@yanndegat
Copy link
Collaborator

ok thanks a log, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants