Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dedicated server (and (me_)_installation_template ) #639

Merged
merged 11 commits into from
May 3, 2024

Conversation

bigbigbang
Copy link
Contributor

@bigbigbang bigbigbang commented Apr 30, 2024

Description

Update of dedicated_me_installation_template

  • remove deprecated attributes
  • add attributes (end_of_install, subfamily, no_partitioning)

Update of type_installation_template

Add dedicated_installation_template data source

Remove resource me_ssh_key(s)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

make testacc TESTARGS="-run TestAccInstallationTemplateDataSource_basic"

  • Test A: make testacc TESTARGS="-run TestAccMeInstallationTemplatesDataSource_basic"
  • Test B: make testacc TESTARGS="-run TestAccInstallationTemplateDataSource_basic"
  • Test C: make testacc TESTARGS="-run TestAccMeInstallationTemplateResource_basic"

Test Configuration:

  • Terraform version: terraform version: Terraform 1.6.6
  • Existing HCL configuration you used:
data "ovh_dedicated_server" "server" {
  service_name = "nsxxxxx.ip-123-123-123.eu"
}

data "ovh_dedicated_installation_template" "ovhtemplate" {
  template_name = "win2019-dc_64"
}

output "template" {
  value = data.ovh_dedicated_installation_template.ovhtemplate
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

ovh/data_dedicated_installation_template.go Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template.go Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template.go Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template_test.go Outdated Show resolved Hide resolved
ovh/data_me_installation_template.go Outdated Show resolved Hide resolved
website/docs/d/me_installation_template.html.markdown Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template.go Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template_test.go Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template_test.go Outdated Show resolved Hide resolved
ovh/data_me_installation_template.go Outdated Show resolved Hide resolved
website/docs/d/me_installation_template.html.markdown Outdated Show resolved Hide resolved
@bigbigbang bigbigbang force-pushed the update_dedicated_server branch 2 times, most recently from 175e3b7 to 94790f6 Compare May 2, 2024 14:52
.cds/terraform-provider-ovh.yml Outdated Show resolved Hide resolved
ovh/data_dedicated_installation_template_test.go Outdated Show resolved Hide resolved
reformat provider.go
add test TestAccDedicatedInstallationTemplateDataSource_basic on CDS
@amstuta amstuta merged commit d6bf283 into ovh:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants