feat: add IN and NOTIN to step condition operators #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loopfz
reviewed
Apr 16, 2020
engine/step/condition.go
Outdated
| func matchList(valStr, expStr string) bool { | ||
| values := strings.Split(expStr, ",") | ||
| for _, v := range values { | ||
| if valStr == v { |
There was a problem hiding this comment.
I'm always paranoid about whitespaces messing up comparisons.
Should we TrimSpace(v) ?
There was a problem hiding this comment.
If complexity is a problem, we could have a Prepare() step on resolution load
wI2L
force-pushed
the
collection-operators
branch
from
f1d58d1
to
76df58d
Compare
loopfz
reviewed
Apr 16, 2020
| conditions: | ||
| - type: check | ||
| if: | ||
| - value: '{{.step.this.output.items}}' |
There was a problem hiding this comment.
the condition is backwards, isnt it?
foo IS IN foo,bar
There was a problem hiding this comment.
Indeed, it doesn't match the code. Fixing.
|
Looks good overall, 2 issues to address imo:
|
wI2L
force-pushed
the
collection-operators
branch
2 times, most recently
from
338b8bc
to
e57e9a6
Compare
loopfz
reviewed
Apr 17, 2020
wI2L
force-pushed
the
collection-operators
branch
from
c5004f2
to
2225921
Compare
loopfz
reviewed
Apr 17, 2020
wI2L
force-pushed
the
collection-operators
branch
from
2225921
to
385e7df
Compare
rbeuque74
requested changes
Apr 20, 2020
wI2L
force-pushed
the
collection-operators
branch
from
385e7df
to
0f094f0
Compare
|
CDS Report test#600.0 ✘
|
rbeuque74
previously requested changes
Apr 28, 2020
There was a problem hiding this comment.
LGTM for the feature.
Missing: patch of template-schema.json to include the new feature: https://github.com/ovh/utask/blob/master/hack/template-schema.json#L656
Test doesn't pass.
|
CDS Report test#648.0 ✘
|
These operators allows to check that a value is present or not in a list of values. The allowed/disabled values are represented as a comma-separated string. Signed-off-by: William Poussier <william.poussier@gmail.com> Co-Authored-By: Thomas Schaffer <thomas.schaffer@corp.ovh.com>
Signed-off-by: Thomas Schaffer <thomas.schaffer@corp.ovh.com>
loopfz
force-pushed
the
collection-operators
branch
from
923e723
to
6c959c7
Compare
Signed-off-by: William Poussier <william.poussier@gmail.com>
loopfz
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operators allows to check that a value is present or not
in a list of values. The allowed/disabled values are represented
as a comma-separated string.
Feature.
A value cannot be checked against a list of potential candidates in a step condition.
This permits to assert that a value is present or not in a list of acceptable values.
No.