Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: venom as Lib #52

Merged
merged 7 commits into from
Apr 27, 2017
Merged

feat: venom as Lib #52

merged 7 commits into from
Apr 27, 2017

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Apr 9, 2017

Sample usage

func TestVenomTestCase(t *testing.T) {
	v := venom.TestCase(t, "TestVenomTestCase", venom.V{
		"foo": "bar",
	})
	r := v.Do(venom.H{
		"type":   "exec",
		"script": "echo {{.foo}}",
	})
	assert.Equal(t, "bar", r["result.systemout"])
}

still have to improve it; with some docs also

@fsamin fsamin requested review from yesnault and sguiheux April 9, 2017 19:03
@yesnault
Copy link
Member

yesnault commented Apr 9, 2017

close #5

sguiheux
sguiheux requested changes Apr 10, 2017
View reviewed changes
executors/imap/decode.go Outdated
@@ -12,6 +12,7 @@ import (
"net/mail"

log "github.com/Sirupsen/logrus"
"github.com/runabove/venom"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong place

lib/lib.go Outdated
}
}

//Do execuutes a veom test steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one u

lib/lib.go Outdated
}

//H is a map of test parameters
type H map[string]interface{}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P

lib/lib.go Outdated
}

//Do execuutes a veom test steps
func (t *T) Do(teststep H) R {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testStepParam

@sguiheux sguiheux merged commit 4980dcd into master Apr 27, 2017
@fsamin fsamin deleted the lib branch November 3, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsamin @yesnault @sguiheux