update variables and executor loading #708
Conversation
fokion
commented
Aug 4, 2023
fokion
commented
- modify the code to avoid having open readers as it was a potential memory leak, I pass the path instead and use the same ReadFile that closes its reader by default
- load the executors ( dont interpolate them with values as we expect to have them interpolated when we execute a test )
- update the variables to remove any cloning and avoid any other duplication
- reporting of testsuites as they get executed to the file format and only the html will be done in the end ( that can be improved further but it is a start)
- added a flag ( you need to set it to ON ) for adding a timestamp with hours.minutes.seconds.milliseconds in the dump.json files and that is useful if you have an executor that is reused multiple times and you want to see all the states and not only the last one.
- skip is updated ( due to the variables change mostly )
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
fokion
force-pushed
the
feat/update-variables
branch
from
e8dc6e2
to
a8d42f0
Compare
|
Linking #701 |
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
fokion
force-pushed
the
feat/update-variables
branch
from
6bfca73
to
c99c55f
Compare
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
… not to overwrite the dump of a reused executor Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
fokion
force-pushed
the
feat/update-variables
branch
2 times, most recently
from
91e08f4
to
824f207
Compare
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
fokion
force-pushed
the
feat/update-variables
branch
from
824f207
to
b3b2473
Compare
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
… based on the documentation Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
|
CDS Report build-venom-a#87.0 ✘
|
|
CDS Report build-venom-a#87.1 ✘
|
|
CDS Report build-venom-a#88.0 ✘
|
|
@fokion Thank you for this proposal. There is so many new code in this Pull-Request, new env var, new code on assertions, configData update. It's pretty hard to review that and will be impossible to rollback the commit if there some issue with something. Can you re-open previous PR (or new prs) dedicated on each fix / feature please? We had discussions on some of them, as #685 About flag, is there any perf data before and after adding the flag VENOM_NO_JSON_EXPANSION ? The Integration Tests are failing with: |
Yes when you have big json payloads that you only need a one or two fields , it crawls after a while while the memory goes really high. I will have a look at that test , but in general it is stable enough as I have been using this fork for a while
|
| @@ -158,6 +170,7 @@ type ConfigFileData struct { | |||
| StopOnFailure *bool `json:"stop_on_failure,omitempty" yaml:"stop_on_failure,omitempty"` | |||
| HtmlReport *bool `json:"html_report,omitempty" yaml:"html_report,omitempty"` | |||
| Variables *[]string `json:"variables,omitempty" yaml:"variables,omitempty"` | |||
| Secrets *[]string `json:"secrets,omitempty" yaml:"secrets,omitempty"` | |||
| @@ -195,6 +208,11 @@ func initFromReaderConfigFile(reader io.Reader) error { | |||
| variables = mergeVariables(varFromFile, variables) | |||
| } | |||
| } | |||
| if configFileData.Secrets != nil { | |||
I could not replicate the test error , will try to run it as a unit test case. |
|
started splitting it into parts
|
|
see splitted pr above. |
