Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag VENOM_LOGS_WITH_TIMESTAMP #722

Closed
wants to merge 1 commit into from

Conversation

fokion
Copy link
Contributor

@fokion fokion commented Sep 27, 2023

When we are emitting the logs of an executor with the flag vv we will be overwriting with the logs of that last execution for that executor. In order to have unique logs and capture every step we need to have the timestamp in the name of the json file.

… not to overwrite the dump of a reused executor

Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fokion , thank you for this proposition.

For those who read this pull-request, the issue is about that:

❯ ./venom run -vv b.yml
          [trac] writing venom.log
 • Hide Secret (b.yml)
        • myvar_first
                • exec PASS
                  [trac] writing b.myvar_first.step.0.0.dump.json
        • myvar_first
                • exec PASS
                  [trac] writing b.myvar_first.step.0.0.dump.json

Here, we have two files, with the same filename

We don't want to add a new flag about that, and perhaps that we can have a filename containing the testcase number.
As these files are linked to the venom.x.log file too, perhaps that we can add the x number is the filename too (and explain the dump.json filename parts in the readme).

@ivan-velasco
Copy link
Contributor

The testcase number is helpful, ideally the testsuiteName_testcaseNumber would make it easier to identify which log to view when errors occur.

@yesnault
Copy link
Member

see #729

@yesnault yesnault closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants