Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: batch loadbalancer acl updates #1378

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jun 3, 2020

Save on some nbctl calls.

- What this PR does and why is it needed
Improve efficiency by batching some bulk changes to logical switch ACLs on service changes.

- Description for the changelog
Improve efficiency when handling service creation and deletion.

Save on some nbctl calls.

Signed-off-by: Casey Callendrello <cdc@redhat.com>
@squeed
Copy link
Contributor Author

squeed commented Jun 3, 2020

/cc @trozet

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 52.736% when pulling a2a0fe1 on squeed:lb-acl-batch into 14ea1f4 on ovn-org:master.

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trozet
Copy link
Contributor

trozet commented Jun 4, 2020

@alexanderConstantinescu you want to take a look?

Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants