Various service fixes #1839
Merged
Various service fixes #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dave-tucker @dcbw @danwinship PTAL |
|
/hold |
dave-tucker
approved these changes
Nov 13, 2020
| @@ -119,7 +119,13 @@ func (l *localPortWatcher) AddService(svc *kapi.Service) { | |||
| } | |||
|
|
|||
| func (l *localPortWatcher) UpdateService(old, new *kapi.Service) { | |||
| if reflect.DeepEqual(new.Spec, old.Spec) { | |||
| if reflect.DeepEqual(new.Spec.Ports, old.Spec.Ports) && | |||
There was a problem hiding this comment.
LGTM....
But just a though. Could we move this check up to gateway.AddService?
Then we'd only need to do it once, and not have it done in multiple places?
There was a problem hiding this comment.
I thought about that, but I saw other handlers have different checks like look at port claim watcher:
if reflect.DeepEqual(old.Spec.ExternalIPs, new.Spec.ExternalIPs) && reflect.DeepEqual(old.Spec.Ports, new.Spec.Ports) {
return
}
Code was accidentally doing an add for localPortWatcher when it should be deleting. Also, the comparison for if a service needs update was insufficient. Changed it to use the same check as ovnkube-master uses for services. Note, a separate commit will be coming to fix shared gw mode. Signed-off-by: Tim Rozet <trozet@redhat.com>
trozet
force-pushed
the
fix_node_service_watching
branch
from
ba2204e
to
b93b52e
Compare
|
Tested it locally and now I'm able to reach the lb ingress service. /hold cancel |
dave-tucker
approved these changes
Nov 13, 2020
|
/retest |
|
/lgtm |
kyrtapz
pushed a commit
to kyrtapz/ovn-kubernetes
that referenced
this pull request
Sep 6, 2023
OCPBUGS-17731: move clearInitialNodeNetworkUnavailableCondition to clustermanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was accidentally doing an add for localPortWatcher when it should
be deleting. Also, the comparison for if a service needs update was
insufficient. Changed it to use the same check as ovnkube-master uses
for services.
Note, a separate commit will be coming to fix shared gw mode.
Signed-off-by: Tim Rozet trozet@redhat.com