fix for the linter

[JacobTanenbaum]

there seems to be a regression in golangci-lint where the "--modules-download-mode=vendor"
is not supported. Remove the modules-download-mode until the regression
is fixed

Regression Issue: golangci/golangci-lint#1502

Signed-off-by: Jacob Tanenbaum jtanenba@redhat.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

[coveralls]

Coverage increased (+0.01%) to 54.263% when pulling 0a9ef9f on JacobTanenbaum:linter-fix into c97eff0 on ovn-org:master.

[abhat]

Should we pin to 1.33.2 of golangci-lint instead?

[JacobTanenbaum]

that might be a better solution. @abhat would it be better to use docker to launch the linter and pin the version that way so that no matter what linter people have locally the same version as CI will be run?

[girishmg]

@JacobTanenbaum that is what I did downstream over the weekend to fix the issue.

[gmoodalbail@gmoodalbail-mlt:~/gowork/src/github.com/ovn-org/ovn-kubernetes/go-controller]
>git diff
diff --git a/go-controller/Makefile b/go-controller/Makefile
index a77e15f9..4133a874 100644
--- a/go-controller/Makefile
+++ b/go-controller/Makefile
@@ -10,6 +10,9 @@ GOPATH ?= $(shell go env GOPATH)
 TEST_REPORT_DIR?=$(CURDIR)/_artifacts
 export TEST_REPORT_DIR
+# Hack for SDN-663
+TAG=v1.33.0
+
 .PHONY: all build check test
 # Example:
@@ -45,7 +48,7 @@ clean:
 .PHONY: install.tools lint gofmt
 install.tools:
-       curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b ${GOPATH}/bin
+       curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b ${GOPATH}/bin ${TAG}
 lint:
        @GOPATH=${GOPATH} ./hack/lint.sh

[abhat]

@JacobTanenbaum that is what I did downstream over the weekend to fix the issue.

[gmoodalbail@gmoodalbail-mlt:~/gowork/src/github.com/ovn-org/ovn-kubernetes/go-controller]
>git diff
diff --git a/go-controller/Makefile b/go-controller/Makefile
index a77e15f9..4133a874 100644
--- a/go-controller/Makefile
+++ b/go-controller/Makefile
@@ -10,6 +10,9 @@ GOPATH ?= $(shell go env GOPATH)
 TEST_REPORT_DIR?=$(CURDIR)/_artifacts
 export TEST_REPORT_DIR
+# Hack for SDN-663
+TAG=v1.33.0
+
 .PHONY: all build check test
 # Example:
@@ -45,7 +48,7 @@ clean:
 .PHONY: install.tools lint gofmt
 install.tools:
-       curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b ${GOPATH}/bin
+       curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b ${GOPATH}/bin ${TAG}
 lint:
        @GOPATH=${GOPATH} ./hack/lint.sh

Yep, this is exactly what I was thinking of. It may be useful to write a Dockerfile and run the linter that way to create a hermetic environment.

[JacobTanenbaum]

@abhat there is already a way to run the linter in docker docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.34.1 golangci-lint run -v from https://golangci-lint.run/usage/install/ I will get this up soon with a tagged version 1.33.2

[JacobTanenbaum]

@abhat @girishmg how does this look?

[trozet]

/lgtm

[abhat]

/lgtm