Bug 1892472: Run linter, utests, and gofmt in container #428
Conversation
upgrading the linter hits the regression below Regression in golangci-lint: golangci/golangci-lint#1502 pin the version of the linter and run the linter in docker to ensure a single version is used by CI and locally by developers Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> (cherry picked from commit 0a9ef9f)
Allows for running tests inside of a container using docker or podman. Signed-off-by: Vishwanath Jayaraman <vjayaram@redhat.com> Co-authored-by: Aniket Bhat <anbhat@redhat.com> (cherry picked from commit a666cbc)
openshift-ci-robot
added
the
approved
|
/assign @trozet @alexanderConstantinescu |
|
/test e2e-metal-ipi-ovn-ipv6 |
abhat
changed the title
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-medium
|
@abhat: This pull request references Bugzilla bug 1892472, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhat: This pull request references Bugzilla bug 1892472, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-openstack-ovn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, alexanderConstantinescu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -9,6 +9,18 @@ PKGS ?= | |||
| GOPATH ?= $(shell go env GOPATH) | |||
| TEST_REPORT_DIR?=$(CURDIR)/_artifacts | |||
| export TEST_REPORT_DIR | |||
| GO_DOCKER_IMG = quay.io/giantswarm/golang:1.15.7 | |||
There was a problem hiding this comment.
The standard is to use golang:1.15-alpine, which I realize is DockerHub. We could make this overridable with a ?= and point to a CI-hosted image for automated runs.
There was a problem hiding this comment.
Yeah, we can make this a downstream specific change. I think anything that is not hosted in Dockerhub which is relatively "official" will work.
Do you feel ok with merging this for now since this is a cherry-pick of upstream and I will create a downstream only PR to update that image to CI-hosted one?
There was a problem hiding this comment.
it was mostly curiosity, not a blocking question :)
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhat: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-gcp-ovn |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhat: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1892472 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick changes from github.com/ovn-org/ovn-kubernetes#1935 and github.com/ovn-org/ovn-kubernetes#1976 for running lint, gofmt, and utest jobs in containers.
Signed-off-by: Aniket Bhat anbhat@redhat.com