allows for running all tests inside a container

[vjayaramrh]

Co-authored-by: Aniket Bhat anbhat@redhat.com
Signed-off-by: Vishwanath Jayaraman vjayaram@redhat.com

- What this PR does and why is it needed

This PR adds the ability to run tests (including those requiring sudo such as tests in pkg/node and hybrid-overlay/pkg/controller) inside of a golang 1.15 docker container. Allows for running tests on non-linux systems as well.

- Special notes for reviewers

- How to verify it

Execute make check or make test on your development system that has docker installed from the ovn-kuberentes/go-controller directory.

- Description for the changelog

[coveralls]

Coverage decreased (-0.5%) to 54.666% when pulling ab4130f on vjayaramrh:dockerize_tests into 9c1fca2 on ovn-org:master.

[abhat]

why not make this replace the check and test targets?

[vjayaramrh]

why not make this replace the check and test targets?

Allows for the choice of running tests on systems where docker is not installed. However, if there is a consensus, I can implement your suggestion.

[girishmg]

@vjayaramrh this looks very good as is. I am going to start using this on my Macbook once this integrates.

Can you please also add make, make lint, and make gofmt?

@abhat as a good point. I am fine either ways not sure what @dcbw @trozet think?

@aojea will it have any impact in Github's ci/cd?

[aojea]

@aojea will it have any impact in Github's ci/cd?

from the top of my head it shouldn't

why not make this replace the check and test targets?

You should keep an option for people without docker/podman installed, I think that just checking if docker exists should be enough

This is really nice, so we have consistency +1 to making it the default

[vjayaramrh]

@vjayaramrh this looks very good as is. I am going to start using this on my Macbook once this integrates.

Can you please also add make, make lint, and make gofmt?

@abhat as a good point. I am fine either ways not sure what @dcbw @trozet think?

@aojea will it have any impact in Github's ci/cd?

@girishmg Looks like hack/lint.sh is already invoking a docker container, let me see what I can do in this PR related to make gofmt

[vjayaramrh]

@aojea will it have any impact in Github's ci/cd?

from the top of my head it shouldn't

why not make this replace the check and test targets?

You should keep an option for people without docker/podman installed, I think that just checking if docker exists should be enough

This is really nice, so we have consistency +1 to making it the default

@aojea let me see if I can do a check for docker installed and keep the same targets as suggested by @abhat

[aojea]

/lgtm
Thanks

[abhat]

nit: GO_DOCKER_IMG instead of GO_DKR_IMG.
Also, what is the need for a buster image?

[abhat]

As an aside, I ran into docker pull limits when pulling this image. Do we just assume that the buster image is hosted on a registry that is pullable in the env where this runs?

[vjayaramrh]

@abhat, I am using the official go image from the docker registry, so most folks that have docker installed should be able to pull from the docker registry. Do you have any additional suggestions?

Per the snippet from the article at https://www.docker.com/blog/checking-your-current-docker-pull-rate-limits-and-status/ do you think this would be an issue?

Anonymous free users will be limited to 100 pulls per six hours, and authenticated free users will be limited to 200 pulls per six hours.

[trozet]

/lgtm