ovnkube-node: add support for comma-separated IPs in external_ids:ovn-encap-ip

[l8huang]

external_ids:ovn-encap-ip can be a list of IP address separted by comma, ovnkube-node should be able to startup without issue.

[coveralls]

coverage: 51.949% (-0.003%) from 51.952%
when pulling 486a1ea on l8huang:encaps
into d3726b0 on ovn-org:master.

[trozet]

Does having multiple encap-ips actually do anything with how OVNK configures OVN? @dceara maybe you can comment here. I'm not sure with OVN IC if we would even setup multiple tunnels if there were multiple encap ips provided.

[l8huang]

Thanks for looking at this PR @trozet.

Does having multiple encap-ips actually do anything with how OVNK configures OVN?

For current upstream, it doesn't. This is just for making ovn-k8s works with legit external_ids:ovn-encap-ip value.

A feature added to OVN to support multi encap ips(see ovn-org/ovn@41eefcb, it depends on the change in this PR), the corresponding feature on ovn-k8s will be pushed later.

[dceara]

Thanks for looking at this PR @trozet.

Does having multiple encap-ips actually do anything with how OVNK configures OVN?

For current upstream, it doesn't. This is just for making ovn-k8s works with legit external_ids:ovn-encap-ip value.

A feature added to OVN to support multi encap ips(see ovn-org/ovn@41eefcb, it depends on the change in this PR), the corresponding feature on ovn-k8s will be pushed later.

Just a note, this requires bumping the OVN version used in CI to the freshly released OVN 24.03.0.

[l8huang]

Just a note, this requires bumping the OVN version used in CI to the freshly released OVN 24.03.0.

Nope, this change doesn't require OVN version change. Supporting comma-separated IPs in external_ids:ovn-encap-ip is a old feature.

[dceara]

Just a note, this requires bumping the OVN version used in CI to the freshly released OVN 24.03.0.

Nope, this change doesn't require OVN version change. Supporting comma-separated IPs in external_ids:ovn-encap-ip is a old feature.

I was under the impression that without ovn-org/ovn@41eefcb only the first IP will be used.

[l8huang]

yes, now only the firstly IP is used, this PR just allow it to be a list. Another PR will be pushed later for corresponding changes in ovn-k8s for ovn-org/ovn@41eefcb.

[trozet]

I think it would be better to hold off on merging this PR, until the full functionality is introduced. Otherwise we are just adding a config option that isn't being used.

[l8huang]

I think it would be better to hold off on merging this PR, until the full functionality is introduced. Otherwise we are just adding a config option that isn't being used.

This change is not bound to the new multi encap ips feature added by ovn-org/ovn@41eefcb -- external_ids:ovn-encap-ip supports comma-separated IPs before that. That's the reason this change is submitted separately.

If there is any concern regarding this PR, it is okay to hold off on this change.

[trozet]

Please reopen when the full feature/use case is identified that we want to enable in ovnk.