Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If one mod throws an exception in Configure all mod settings break #452

Closed
xen-42 opened this issue Jun 13, 2022 · 0 comments · Fixed by #454
Closed

If one mod throws an exception in Configure all mod settings break #452

xen-42 opened this issue Jun 13, 2022 · 0 comments · Fixed by #454

Comments

@xen-42
Copy link
Member

xen-42 commented Jun 13, 2022

Seems that when you change the settings for one mod, it runs Configure on all mods. If a mod throws an exception (happens often on the main menu because many creators don't handle NRE stuff properly since they expect you to be in the main scene) then your settings don't get updated even if you're trying to change the value for a mod that has no issues.

Specifically, happens to me when changing New Horizons settings from the main menu with Third Person Camera installed. Camera mod throws an exception so the New Horizons Configure doesn't run.

Raicuparta pushed a commit that referenced this issue Jun 13, 2022
…453)

* Fixed #452 (exceptions in mod settings break options for other mods)

* put tab instead of spaces
@misternebula misternebula mentioned this issue Jun 13, 2022
@misternebula misternebula linked a pull request Jun 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant