Fixed #452 (exceptions in mod settings break options for other mods) (#…

…453) * Fixed #452 (exceptions in mod settings break options for other mods) * put tab instead of spaces
ow-mods · Jun 13, 2022 · 01a0468 · 01a0468
1 parent 8f09992
commit 01a0468
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/OWML.Launcher/OWML.Manifest.json b/src/OWML.Launcher/OWML.Manifest.json
@@ -2,7 +2,7 @@
   "author": "Alek",
   "name": "OWML",
   "uniqueName": "Alek.OWML",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "minGameVersion": "1.1.10.47",
   "maxGameVersion": "1.1.12.201"
 }
diff --git a/src/OWML.ModHelper.Menus/ModConfigMenu.cs b/src/OWML.ModHelper.Menus/ModConfigMenu.cs
@@ -1,6 +1,7 @@
 using OWML.Common;
-using System.Linq;
 using OWML.Common.Menus;
+using System;
+using System.Linq;
 
 namespace OWML.ModHelper.Menus
 {
@@ -53,7 +54,17 @@ protected override void OnSave()
 				}
 			}
 			ModData.Storage.Save(ModData.Config, Constants.ModConfigFileName);
-			Mod?.Configure(ModData.Config);
+
+			// Fixes "If one mod throws an exception in Configure all mod settings break" (#452)
+			try
+			{
+				Mod?.Configure(ModData.Config);
+			}
+			catch (Exception e)
+			{
+				Console.WriteLine($"Exception thrown when changing mod settings: {e.Message}, {e.StackTrace}", MessageType.Error);
+			}
+
 			Close();
 		}