Fix meta-actions not being applied if multiMatch is enabled in the chain starter rule #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlevogiannis
changed the title
mlevogiannis
force-pushed
the
v3/fix-multimatch-chain
branch
from
b71a112
to
1e6184b
Compare
|
I agree with this change. It successfully brings the output closer to what users' reasonable expectations likely are. (There are still some oddities with chain combined with multiMatch, but this PR doesn't appear to make any of those things worse.) The only thing that really ought to be changed with this PR is in the automated test: it would be better if each SecRule in the same chain appears on its own line. It's easier to read that way -- not to mention making it more consistent with other examples that use 'chain' in the automated test suite. |
…ain starter rule Meta-actions can only be used in non-chained rules or in the chain starter rule of a rule chain. The m_chainedRuleParent member of the RuleWithActions class is NULL only if the rule is not chained or if it is the chain starter rule of a rule chain. Fixes owasp-modsecurity#2867.
mlevogiannis
force-pushed
the
v3/fix-multimatch-chain
branch
from
1e6184b
to
12add9a
Compare
|
@martinhsv Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2867.
(This PR will be marked as ready after #2866 is merged and the new regression tests are updated to also check for the tags in the audit log.)