Include Attribute Mutator on Audit Formatting #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After we have tests and doc I can merge it. Would someone be able to help us? |
- Extended the itResolvesAuditData, itResolvesAuditDataIncludingUserAttributes, itReturnsTheAppropriateAuditableDataValues, itReturnsAuditableModifiedAttributesAsArray, itReturnsAuditableModifiedAttributesAsJsonString, to validate the behavior of attribute mutator. - Add content mutator in Article model
|
@anteriovieira The change aligns with standard Laravel behavior, so there's no need for documentation updates. While it may seem like a new feature, it's essentially a bug-fix for Laravel's attribute mutators. |
|
Thanks @hamedghaderi. We do however run into an issue. The named parameters in the new laravel style would only work from PHP 8.0 and v13 support 7.4 On v8.0 and upo, the test fails, but i haven't looked into why yet |
Fix tests
MortenDHansen
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This pull request addresses the issue of the Audit functionality in the Laravel framework failing to include attribute accessors during the formatting process.
Solution
To solve this issue, I have made modifications to the Audit functionality. The changes now include attribute accessors when formatting the data. This ensures that any custom formatting defined through attribute accessors is properly considered.
Related Issue #828
Checklist