New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload to s3 for private files - Updated #851

Merged

westonganger merged 6 commits into owen2345:master from westonganger:fix/private-file-upload

Oct 23, 2018

Collaborator

westonganger commented Oct 19, 2018 •

edited

Fix tests for [WIP] Fix upload to s3 for private files #830
Also I removed phantomjs/poltergeist from the test suite because it was incorrectly saying the invalid test was passing when it should have failed, plus a whole other bunch of issues it causes.
Some random readme improvements tucked in here too

max2320 and others added 6 commits

July 23, 2018 15:52


          fix upload to s3 for private files

9931e11


          Media validation includes :is_public

77d6265


          Merge branch 'master' into fix/private-file-upload

b7f0a1e


          improvements

bc4f400


          Merge branch 'improvements' into fix/private-file-upload

3e40fac


          Fix upload to s3 for private files

e684c62

Collaborator Author

westonganger commented Oct 19, 2018

Tests are passing. Only failed on 2.5 and ruby-head due to flaky db connection.

westonganger merged commit 56398ca into owen2345:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment