Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for gh clone #72

Closed
wants to merge 4 commits into from
Closed

Conversation

tgkokk
Copy link
Collaborator

@tgkokk tgkokk commented Jul 13, 2013

  1. When you run gh clone git://github.com/jingweno/gh gh, gh would transform it into git clone git://github.com/jingweno/gh git://github.com/tgkokk/gh. In other words, it wouldn't stop if it found a URL. I fixed it.
  2. I added noop. (not really a fix)
  3. Now, if gh clone foo bar is run, git clone git@github.com:tgkokk/foo bar is run. It's what hub also does, you can check with hub --noop.

@owenthereal
Copy link
Owner

good findings! Merged with minor fixes: 5351ec4

@tgkokk tgkokk deleted the gh-clone-fix branch July 18, 2013 23:10
@tgkokk
Copy link
Collaborator Author

tgkokk commented Jul 18, 2013

Thanks. Don't merge #71 yet, I will apply the fix about stopping to it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants