-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out inference routines #191
Conversation
As an aside, it would be helpful to add https://pre-commit.ci/ as a bot so that PRs can be autofixed (and more generally, following the scverse cookiecutter https://github.com/scverse/cookiecutter-scverse) |
Just want to again mention the pre-commit here https://github.com/scverse/cookiecutter-scverse/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.pre-commit-config.yaml Ruff is really fast and adoption is rising. It can also fix a lot of the things I'm fixing myself right now :) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@BorisMuzellec I'm not sure how strongly you feel about the test_docstrings file now that ruff should be handling everything. It's failing due to no extended summary |
|
@BorisMuzellec it will probably also help the project to use readthedocs pull request builds https://docs.readthedocs.io/en/stable/guides/pull-requests.html And then building docs can be previewed per PR and removed from the tests. We had done this in scvi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, really brings readability, and will be super useful to devise custom inference routines :) Thanks a lot ! Two very very minor linting suggestions, but feel free to ignore
pydeseq2/inference.py
Outdated
ndarray | ||
Estimated mean. | ||
""" | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ridiculous comment: not sure pass is needed (since there is a docstring)
pydeseq2/dds.py
Outdated
) | ||
for i in self.non_zero_idx | ||
) | ||
MLE_lfcs_, mu_, hat_diagonals_, converged_ = self.inference.irls( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MLE -> mle for case convention ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @adamgayoso for this PR, and sorry for the long wait! I'm finally merging this.
Fixes #187