Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI remove test_docstrings (duplicate with ruff, which runs pydocstyle) #196

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

BorisMuzellec
Copy link
Collaborator

@BorisMuzellec BorisMuzellec commented Oct 26, 2023

Reference Issue or PRs

#191

What does your PR implement? Be specific.

test_docstrings runs numpydoc.validate, but now that the CI runs pydocstyle via ruff, it's no longer necessary.

@BorisMuzellec BorisMuzellec merged commit ae2d6b7 into main Oct 26, 2023
13 checks passed
@BorisMuzellec BorisMuzellec deleted the remove_test_docstrings branch October 26, 2023 15:11
BorisMuzellec added a commit to adamgayoso/PyDESeq2 that referenced this pull request Oct 27, 2023
BorisMuzellec added a commit that referenced this pull request Nov 24, 2023
* Create inference.py

* Create default_inference.py

* Update dds.py

* Update ds.py

* Update plot_minimal_pydeseq2_pipeline.py

* Update plot_pandas_io_example.py

* Update plot_step_by_step.py

* don't process non-zeros in utils

* Update dds.py

* formatting

* formatting

* ignore typing

* ignore typing

* docstrings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* noqa

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* docstrings

* CI  remove test_docstrings (duplicate with ruff, which runs pydocstyle) (#196)

* docs: fix docs, incorporate new classes

* refactor: remove pass statements from abstractmethods with docstrings

* style: rename MLE_lfc variable to lowercase mle_lfc

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Boris Muzellec <BorisMuzellec@users.noreply.github.com>
Co-authored-by: Boris MUZELLEC <boris.muzellec@owkin.com>
BorisMuzellec added a commit that referenced this pull request Nov 24, 2023
* split vst functions into fit & transform

* fix leakage of size factors

* handle exceptions and document specific cases and functions

* update tests

* fix docstring

* CI: Add ruff pre-commit hook (#192)

* CI: add ruff

* ci: fix ruff line length argument

* ci: update ruff configuration, remove flake8 and isort

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* CI: integrate isort options to ruff, remove nbqa

* CI: fix force-single-line typo

* CI: add ruff exceptions for sphinx gallery examples

* chore: fix linting

* chore: linting

* ci: add exception to linting for sphinx examples

* docs: renove extra period in sphinx examples

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* CI Remove precommit from workflow (#195)

* CI  remove test_docstrings (duplicate with ruff, which runs pydocstyle) (#196)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor: minor docstring and line comment edits

* refactor: minor docstring and line comment edits

---------

Co-authored-by: SimonGrouard <simon.grouard@owkin.com>
Co-authored-by: Boris Muzellec <BorisMuzellec@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adam Gayoso <adamgayoso@users.noreply.github.com>
Co-authored-by: Boris MUZELLEC <boris.muzellec@owkin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant