Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom target framerates #1138

Closed
bsncubed opened this issue Jun 24, 2021 · 13 comments
Closed

Custom target framerates #1138

bsncubed opened this issue Jun 24, 2021 · 13 comments
Assignees
Labels
admin Issues related to the Admin portion backlog Ideas that might be cool and can be looked into later. enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@bsncubed
Copy link

Hi

Is it possible for you to add 25fps and 50 fps? In v0.05 i could manually edit the config file to make it work, but i can't find a work around now.

@jeyemwey jeyemwey changed the title Using non americal frame rates 25fps and 50fps Custom target framerates Jun 24, 2021
@jeyemwey jeyemwey added the enhancement New feature or request label Jun 24, 2021
@stale
Copy link

stale bot commented Aug 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2021
@gabek gabek added the backlog Ideas that might be cool and can be looked into later. label Aug 23, 2021
@stale stale bot removed the stale label Aug 23, 2021
@gabek
Copy link
Member

gabek commented Aug 23, 2021

I haven't seen others ask for non-standard framerates, but I'll keep this open for a bit to let others chime in. Adding this would add complexity to the configuration and I'm not sure there's many people who would utilize it.

@YohannLYD
Copy link

I too would be interested in having 25/50fps as an option.
This is actually a broadcast standard framerate in the European broadcast sector and haven't been able to use the software in production for this reason.

@gabek
Copy link
Member

gabek commented Aug 31, 2021

If all we want to do is add it to our current selector control, we can do that. I fear it'll start confusing people with too many options and that we would need to change to a completely different way to select framerates. But if somebody wants to add this to the control we can give it a spin.

@gabek gabek added the admin Issues related to the Admin portion label Aug 31, 2021
@YohannLYD
Copy link

If too many framerates is confusing to people (is it really?) I'd be down to replace 24fps with 25fps to keep the number of options to the minimum.
After all 24fps is not really a video standard, but a cinema/film one.

@bsncubed
Copy link
Author

Would you be open to adding 50fps as well? just to keep the feature set on par with the US framerates (30/60)

@gabek
Copy link
Member

gabek commented Aug 31, 2021

I'd be down to replace 24fps with 25fps to keep the number of options to the minimum.

I'm sure you would be ok with it, you're the one who asked for it :)

The concern I have is things are kind of setup to be "low, medium, high, stupid high". So adding more is like saying "low, a different low, medium, another medium"... and that doesn't make a lot of sense to people trying to make a decision. Like why would we have 24 and 25? I know it makes sense to you, but I can see that being kind of weird to normal people.

Just for my own knowledge, why does "broadcast standard" matter when it's the internet? If you were to downsample 25fps to 24fps, what is the major drawback there? I understand if this was broadcast television where standards need to be adhered to or the television won't play back a signal, but internet video is certainly more flexible.

@gabek
Copy link
Member

gabek commented Aug 31, 2021

But again, if somebody wants to add these FPS options let's give it a spin. If nobody does it then I'll eventually get around do it and if it's confusing or the control just doesn't work with it then it'll have to be readdressed.

@YohannLYD
Copy link

Just for my own knowledge, why does "broadcast standard" matter when it's the internet? If you were to downsample 25fps to 24fps, what is the major drawback there? I understand if this was broadcast television where standards need to be adhered to or the television won't play back a signal, but internet video is certainly more flexible.

Because of workflow. I'm not working in a TV channel, but in conditions that uses broadcast settings where I find interesting potential uses for owncast. Like online conferences and such.
I've been testing owncast with a stream coming from a Blackmagick Web Presenter. The camera outputs 25fps to the streaming device. It works well but since the streaming engine (owncast) doesn't provide 25fps, I will have image drops during the stream which could have been avoided.

Similarly if I had to make a video edit that would include a recording of the owncast stream. Having a 24fps source in a 25fps project sequence is a bother for the very same reasons (image drops and maybe audio skips).

@Kunsi
Copy link

Kunsi commented Sep 2, 2021

Maybe we could just have an option to allow arbitrary frame rates? The bitrate setting allows incrementing in 100kbit/s steps, why shouldn't the framerate selector do the same?

@oixtron
Copy link

oixtron commented Sep 2, 2021

Maybe we could just have an option to allow arbitrary frame rates? The bitrate setting allows incrementing in 100kbit/s steps, why shouldn't the framerate selector do the same?

I second that suggestion. Hiding that option behind another menu won't "confuse" anyone imo. But also, 25 and 50 fps aren't arbitrary at all and besides professional TV and broadcasting, 50fps is a de facto standard for video refresh rates here in Europe.

@aaronpk
Copy link
Contributor

aaronpk commented Sep 2, 2021

I would not recommend a slider for setting arbitrary frame rates. But I would recommend adding the standard Europe frame rates, 25 and 50fps

@gabek gabek added the good first issue Good for newcomers label Sep 12, 2021
@controlfreakstudio
Copy link

assign pls. I have some changes tested to propose based on balance and the above input. will offline a small chicken vs egg paradox.

controlfreakstudio added a commit to controlfreakstudio/owncast-admin that referenced this issue Oct 6, 2021
This is a technically correct and low to no risk making the low end default 25.

The paradox is I am having heck of a time locating how the initial default stream output is setup anywhere in the owncast deployment. It is not a big deal as anyone who doesnt care will have the default 24fps anyone who does care will go to advanced and make their own variant and delete the default. 

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50.  So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

I don't feel this is overwhelming or confusing  as it is in Advanced, and it's is legit nice for source for the world users...

tested with all variants incl the 24 default I have yet to kill stacked with no issues.
controlfreakstudio added a commit to controlfreakstudio/owncast-admin that referenced this issue Oct 10, 2021
owncast/owncast#1138

This is a technically correct and low to no risk making the low end default 25.

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50.  So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

I don't feel this is overwhelming or confusing  as it is in Advanced, and it's is legit nice for source for the world users...

Pardon my ignorance bu I cannot find where the default stream output name is coming from, tried reinstalling owncast on top of my updated admin but it still sticks a defualt NAME of "1.2Mpbs@24fps" in the admin UI even though create and edit work great with the above changes.


This is a technically correct and low to no risk making the low end default 25.

The paradox is I am having heck of a time locating how the initial default stream output is setup anywhere in the owncast deployment. It is not a big deal as anyone who doesnt care will have the default 24fps anyone who does care will go to advanced and make their own variant and delete the default. 

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50.  So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

tested streaming with all variants individually and stacked the with no issues.
controlfreakstudio added a commit to controlfreakstudio/owncast-admin that referenced this issue Oct 11, 2021
owncast/owncast#1138
This is a technically correct and low to no risk making the low end default 25.

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50. So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

Pardon my ignorance but I cannot find where the heck the default visual stream options name only is being generated. I've tried reinstalling owncast on top my edited admin no dice.

tested with all variants individual and stacked with no issues.
@gabek gabek closed this as completed Oct 14, 2021
gabek pushed a commit that referenced this issue Apr 26, 2022
* framerates #1138


#1138
This is a technically correct and low to no risk making the low end default 25.

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50. So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

Pardon my ignorance but I cannot find where the heck the default visual stream options name only is being generated. I've tried reinstalling owncast on top my edited admin no dice.

tested with all variants individual and stacked with no issues.

* Update config-constants.tsx

per discussion reintroduced the 24fps default thus removing any paradox with the core code text visual naming
removed NA , EU references

re-tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issues related to the Admin portion backlog Ideas that might be cool and can be looked into later. enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

8 participants