Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video.js and use standalone more recent videojs http streaming #133

Closed
gabek opened this issue Aug 28, 2020 · 3 comments
Closed

Update video.js and use standalone more recent videojs http streaming #133

gabek opened this issue Aug 28, 2020 · 3 comments
Assignees
Labels
Web frontend Issues dealing with the web site
Milestone

Comments

@gabek
Copy link
Member

gabek commented Aug 28, 2020

I'm working on #9 and trying to address #85 (stream is offline content) at the same time and I was having a lot of inconsistency in playback. Yet using VideoJS's test page at https://videojs-http-streaming.netlify.app always worked. As a test I thought I'd manually bring in whatever version of videojs-http-streaming they're using on their test page and just threw it in our index.html

    <script src="//unpkg.com/video.js@7.9.3/dist/video.min.js"></script>
    <script src="https://videojs-http-streaming.netlify.app/dist/videojs-http-streaming.min.js"></script>

And while it threw an error about registering a plugin twice (makes sense, since I was manually registering a different version of it on top of whatever comes with videojs) it worked.

I'll wait until all my video changes go in before trying to make any player changes, but this is more of a note to self where to start investigating.

@gabek gabek added the Web frontend Issues dealing with the web site label Aug 28, 2020
@gabek gabek added this to the v0.0.3 milestone Aug 28, 2020
@gabek gabek self-assigned this Aug 28, 2020
@gabek
Copy link
Member Author

gabek commented Sep 1, 2020

It seems the bundled version of http streaming with video.js is 1.13.3 but the version used on https://videojs-http-streaming.netlify.app is version 2.0.0+ https://github.com/videojs/http-streaming/blob/main/package.json#L3.

So I just need to find out how to disable the built-in version of http streaming and use the external, more updated, version.

@gabek
Copy link
Member Author

gabek commented Sep 1, 2020

Looks like the answer is to bring in video.core.min.js instead of the full version of video.js, and then we can use a different (more up to date) version of VHS. But I can't seem to find video.core.min.js on the CDN anywhere. I might just be looking in the wrong place, though.

@gabek
Copy link
Member Author

gabek commented Sep 1, 2020

@gabek gabek closed this as completed in c9451cf Sep 1, 2020
@gabek gabek modified the milestones: v0.0.3, v0.0.2 Sep 1, 2020
@gabek gabek changed the title Videojs videojs-http-streaming inconstancies Update video.js and use standalone more recent videojs http streaming Sep 1, 2020
gabek pushed a commit that referenced this issue Apr 26, 2022
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.8 to 1.32.10.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](sass/dart-sass@1.32.8...1.32.10)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web frontend Issues dealing with the web site
Projects
None yet
Development

No branches or pull requests

1 participant