Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Podcast stops playing when (re)loading a feed #156

Closed
icewind1991 opened this issue May 6, 2013 · 13 comments
Closed

Podcast stops playing when (re)loading a feed #156

icewind1991 opened this issue May 6, 2013 · 13 comments

Comments

@icewind1991
Copy link
Contributor

While listening to an audio podcast in a news reader, when (re)loading a feed the podcasts stops playing because the element gets removed.

A option might be to move the element outside the feed view when the audio is playing.

For long term, it might be nice to integrate it in the media app in a way. (if the media app ever gets fixed properly)

@BernhardPosselt
Copy link
Contributor

Hm it would ofc be cool if you could just listen to the podcast and read the next bunch of headlines if its not interesting. We would require global player controls that would be shown all time which is kinda weird for a feed reader.

There are IMO two better solutions:

  • Integrate with the media app (own playlist podcasts for instance)
  • Open a second window to play the podcast

@jancborchardt

@jancborchardt
Copy link
Contributor

»when reloading a feed« – does that happen 1) without user interaction, or 2) by you explicitly going to a different feed or reloading the browser?

If it’s 1), we need to fix it (by blocking loading when you listen to a podcast) and if it’s 2) we shouldn’t try to do anything on it atm.

@BernhardPosselt
Copy link
Contributor

@jancborchardt 2) very likely

@icewind1991
Copy link
Contributor Author

2, I wanted to read the new items while I was listening to a podcast

@jancborchardt
Copy link
Contributor

Ok, then the fix should simply be to keep the DOM element outside the feed view, like @icewind1991 originally suggested. Other solutions like controls and integration into the music player sound complicated and probably are.

That said, when we have more time maybe we should also aim to optimize the News app for podcasts. I don’t think it should be a different app (because blogs also have audio entries) and neither should it be integrated in the music app, because the only similarity with music is that it’s audio.

@cosenal
Copy link
Contributor

cosenal commented May 7, 2013

👍 I like this. This was in my first original proposal when I applied to GSoC. The app changed too much since then, but this is still in my dreams :)

@BernhardPosselt
Copy link
Contributor

@jancborchardt where should we put the controls? Its quite easy to integrate into the music app btw ;D and i think we should seperate responsibilities well and define the stuff that the news app wont do.

agree that optimizing for podcasts is a cool idea.

@jancborchardt
Copy link
Contributor

I hope you’re not talking about tackling this issue now. It’s out of
scope for the moment because there’s some more pressing stuff like
first run experience.

With »when we have time« I meant after the basic stuff is done. Please
no work on this for now.

@cosenal
Copy link
Contributor

cosenal commented May 7, 2013

Agree, this is for version 2.0 :)

@BernhardPosselt
Copy link
Contributor

Milestone next it is then ;D

@piratenpanda
Copy link

Something like on jamendo would be cool I guess

@BernhardPosselt
Copy link
Contributor

This is tricky if you also think of movies. Do we have a proper design for this yet?

@pmk1c
Copy link

pmk1c commented Feb 9, 2015

I don't think it should be integrated with the music app. The people behind elementaryOS made some good points on that: http://elementaryos.org/journal/why-a-music-app-shouldnt-be-a-podcast-app

BernhardPosselt pushed a commit that referenced this issue Mar 30, 2015
@BernhardPosselt BernhardPosselt modified the milestones: Dreamland, 8.1 Mar 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants