Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some things about the new design #376

Closed
BernhardPosselt opened this issue Jul 24, 2015 · 21 comments
Closed

Some things about the new design #376

BernhardPosselt opened this issue Jul 24, 2015 · 21 comments

Comments

@BernhardPosselt
Copy link
Member

While the new changes are nice I've encountered a few things that bug me:

  • Pull to refresh does not work anymore in the feed and folder overview
  • the star and read system is nice because it's more accurate than before (hitting the star and not opening the article was hard before) but it took me a while to figure out that it worked that way. If you launch the app as a new user is there hint how it works? Something like the intro would be awesome, much like what happens if you launch android after you've set it up
  • the image at the top in the feed overview takes up a lot more space than needed (1/3 on my nexus 5) can we give the actual content more space?
@BernhardPosselt
Copy link
Member Author

@jancborchardt

@BernhardPosselt
Copy link
Member Author

Another thing: it's hard to go back to the feed overview because a pull from left to right often causes the star view to appear. The menu button is hard to reach on today's smart phone displays

@BernhardPosselt
Copy link
Member Author

Maybe put star and mark read on the same side and require starring to be swiped in farther?

@schaal
Copy link
Contributor

schaal commented Jul 24, 2015

Pull to refresh does not work anymore in the feed and folder overview

You can pull-to-refresh in the main content fragment, also you can touch the header in the feed overview to refresh

the image at the top in the feed overview takes up a lot more space than needed (1/3 on my nexus 5) can we give the actual content more space?

Ideally the header would scroll out of view if the content is scrolled up, but I haven't figured out yet how to achieve this. Maybe we could decrease the size for now.

Another thing: it's hard to go back to the feed overview because a pull from left to right often causes the star view to appear. The menu button is hard to reach on today's smart phone displays

Have to say I never experienced this on my Moto G. You have to pull from outside of the screen in to open the drawer, pulling inside starts a swipe on an item.

Maybe put star and mark read on the same side and require starring to be swiped in farther?

I think that would require too much accuracy when swiping and would be even harder to discover (would also be complicated implementation-wise I believe)

@David-Development
Copy link
Member

Maybe put star and mark read on the same side and require starring to be swiped in farther?

I also think it's not a good idea because it's not a known gesture. Swiping left/right is great but bringing in how far you swipe is really hard to discover and requires more attention while performing the gesture.

@schaal Probably we should add the "ShowcaseView" Library again in order to help the user to "discover" the functions/features. I didn't even know that it's possible to start the sync from the folder view by tapping on the app-icon. Unfortunately I'm currently very busy by preparing my semester abroad. So I won't have a lot time for coding in the next few weeks.

@BernhardPosselt
Copy link
Member Author

Have to say I never experienced this on my Moto G. You have to pull from outside of the screen in to open the drawer, pulling inside starts a swipe on an item

Maybe it happens because I'm using a small cover like this one http://www.pdair.com/media/catalog/product/cache/1/image/9df78eab33525d08d6e5fb8d27136e95/s/f/sfrhylgv5_5.jpg which actually has higher edges to prevent the phone from falling onto the display (which i suspect many people use). Swiping in from the edge is just very hard although the frame is very thin.

What about using something like iOS does in the mail app for instance
ios-8-mail-gestures1

Here you swip the item from right to left and get X possilbe buttons with actions on them, swiping from left to right could then exclusively open the main menu

You can pull-to-refresh in the main content fragment, also you can touch the header in the feed overview to refresh

Yes realized it but it always feels wrong to pull down in a subsection of a feed or folder to refresh everything. Basically refreshing all feeds and folders makes sense in the all feeds and folders view. Clicking on the icon is nice but also not well discoverable.

@BernhardPosselt
Copy link
Member Author

Yes tried it again: I need roughly 5 swipes from left to right to open the feed and folder overview

@schaal
Copy link
Contributor

schaal commented Jul 25, 2015

I just pushed PR #378, which increases the margin that allows to open the drawer. Can you try if this improves things for you?

David-Development added a commit that referenced this issue Jul 25, 2015
(Partial) Fix for some design issues as discussed in #376
@David-Development
Copy link
Member

Okay, update is on GooglePlay and GitHub now.

@BernhardPosselt
Copy link
Member Author

Way better :)

@BernhardPosselt
Copy link
Member Author

IMHO just pull to refresh left. In addition you could also replace the news icon with an icon that e.g. https://www.google.at/search?q=update+icon&oe=utf-8&gws_rd=cr&hl=de&sa=X&oi=image_result_group&ved=0CAsQsARqFQoTCOye1bjz9cYCFYSHLAodOi8JWw&tbm=isch

@schaal
Copy link
Contributor

schaal commented Jul 25, 2015

I think that would be more counterintuitive. The pull-to-refresh should be on the content you want to refresh, which in this case are the feed items in the main view. Also this would then be the only app I know with a ptr in the navigation view.

But we could add an indicator that touching the nav header refreshes the content.

@BernhardPosselt
Copy link
Member Author

Why? These are two different views that you can refresh. Think of the following usecase:

  • you're finished reading
  • you want to see what other feeds have left and read those, e.g. I'm finished reading cooking recipes, now I would like to check the newest headlines

So you change into the main view where the news headlines folder is and want to pull down to refresh and check if something new came in. It's counter intuitive to pull down to refresh in the recipes section because I don't want to check the newest recipes, I want to read the headlines ;)

@schaal
Copy link
Contributor

schaal commented Jul 25, 2015

Sure, but you still want to get new feed items and not new folders. And you can always touch the header to update from the navigation drawer.

Just for reference, the material design guidelines specifically discourage adding a pull-to-refresh in the navigation view:

Swipe to refresh should not be used in the following situations:

  • Navigation drawers
  • Home screen widgets
  • Pannable content

http://www.google.com/design/spec/patterns/swipe-to-refresh.html#swipe-to-refresh-swipe-to-refresh

@BernhardPosselt
Copy link
Member Author

Well I want to refresh all folders and feeds and check where to go from there. And I also want to get new folders and feeds.

Pull to refresh is nice because my phone screen is 5" and the icon is impossible to hit with one hand. As for the guidelines: there's probably a reason for it and I think this kind of app is an exception

@BernhardPosselt
Copy link
Member Author

As in I don't think that the app has a traditional static navigation.

@BernhardPosselt
Copy link
Member Author

As for checking the folders: I'm actually interested in the unread count which is shown in the folders and feeds view

@stefan-niedermann
Copy link
Member

The current "Press the Icon to refresh" is very unnatural and as a user i got very confused about it (didn't knew it til i pressed it accidently). what i expected: pull to refresh in detail view refreshes items in detail view, pull to refresh in navigation view refreshes the whole account (folders, feeds, feed counters and last not least items).
Why ptr instead of button click? it's a common pattern, it's already used in the app and i don't have to hit a small area at the top of my screen.

about starring: i think its very hard, too. there are two different swipe-from-left-actions. @Radyation pointed in another ticket out, like gmail does it (star button on bottom right on each item). i think this is the way to go, since you will only have one swipe-from-left-action left. much less confusing and frustrating.

@BernhardPosselt
Copy link
Member Author

PS: after accustoming myself to the new UI I basically don't use pull to refresh anymore and just hit the icon :/

@cemrich
Copy link
Contributor

cemrich commented Aug 4, 2015

There is a similar discussion about the pull to refresh feature in issue #320

@David-Development
Copy link
Member

I think this can be closed now. Otherwise please reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants