Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity app in app store? #320

Closed
nickvergessen opened this issue Jul 1, 2015 · 6 comments
Closed

Activity app in app store? #320

nickvergessen opened this issue Jul 1, 2015 · 6 comments

Comments

@nickvergessen
Copy link
Contributor

I need a little help on the decision here. Currently the activity app has a ocsid entry in the info.xml:
https://github.com/owncloud/activity/blob/master/appinfo/info.xml#L22
all the way down to stable7
https://github.com/owncloud/activity/blob/stable7/appinfo/info.xml#L16

However, in the app store there was only a dummy, so if it would have been used to update the app, it would have killed itself? Anyhow, @LukasReschke removed the dummy yesterday to avoid problems.

Now the question is, should we properly maintain the activity app in the appstore, so people can also update it when they are too lazy to update core with the next maintenance release? Or should we just remove the ocsid everywhere and say that it is only available via the normal packages.

@DeepDiver1975 @karlitschek

@karlitschek
Copy link

Great point. So in the past we had the idea that it makes sense to be able to push a new version of a shipped app via the app store to replace the originally shipped app like activity.
Nowadays I think this was a stupid idea and I'm also not sure if this feature still works.
My personal opinion is that we should remove this from the shipped app and kill the feature.

@nickvergessen
Copy link
Contributor Author

Okay, I will then go ahead and remove the ocsid from all stable branches and master of the activity app.

LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/updater that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/updater that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/updater that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/updater that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
@LukasReschke
Copy link
Member

I created PRs for all other applications. Please review as well.

@LukasReschke
Copy link
Member

Ah and because somebody thought it would be a good idea to store the OCSID also in the DB but not automatically delete an existing one if the application has no one in appinfo.xml when updating we also need some other changes. Awesome 🚀

LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value.

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value.

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value.

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud/core that referenced this issue Jul 2, 2015
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value.

Ref owncloud/activity#320 (comment)
@LukasReschke
Copy link
Member

@LukasReschke
Copy link
Member

@nickvergessen Also requires to bump the version and my PRs against master to work reliably.

LukasReschke added a commit to owncloud-archive/gallery-old that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud-archive/gallery-old that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud-archive/gallery-old that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud-archive/gallery-old that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
LukasReschke added a commit to owncloud-archive/gallery-old that referenced this issue Jul 2, 2015
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
DeepDiver1975 pushed a commit to owncloud/user_ldap that referenced this issue Sep 6, 2016
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307

Ref owncloud/activity#320 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants