New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity app in app store? #320
Comments
Great point. So in the past we had the idea that it makes sense to be able to push a new version of a shipped app via the app store to replace the originally shipped app like activity. |
Okay, I will then go ahead and remove the ocsid from all stable branches and master of the activity app. |
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
I created PRs for all other applications. Please review as well. |
Ah and because somebody thought it would be a good idea to store the OCSID also in the DB but not automatically delete an existing one if the application has no one in appinfo.xml when updating we also need some other changes. Awesome 🚀 |
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value. Ref owncloud/activity#320 (comment)
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value. Ref owncloud/activity#320 (comment)
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value. Ref owncloud/activity#320 (comment)
If no OCS ID is specified in appinfo.xml and an app update is triggered and a OCS ID is stored in the DB we should clean the value. Ref owncloud/activity#320 (comment)
Master: owncloud/core#17316 |
@nickvergessen Also requires to bump the version and my PRs against master to work reliably. |
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as owncloud/core#17307 Ref owncloud/activity#320 (comment)
I need a little help on the decision here. Currently the activity app has a ocsid entry in the info.xml:
https://github.com/owncloud/activity/blob/master/appinfo/info.xml#L22
all the way down to stable7
https://github.com/owncloud/activity/blob/stable7/appinfo/info.xml#L16
However, in the app store there was only a dummy, so if it would have been used to update the app, it would have killed itself? Anyhow, @LukasReschke removed the dummy yesterday to avoid problems.
Now the question is, should we properly maintain the activity app in the appstore, so people can also update it when they are too lazy to update core with the next maintenance release? Or should we just remove the ocsid everywhere and say that it is only available via the normal packages.
@DeepDiver1975 @karlitschek
The text was updated successfully, but these errors were encountered: