Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] Remove OCS IDs #17314

Merged
merged 1 commit into from Jul 2, 2015
Merged

[stable7] Remove OCS IDs #17314

merged 1 commit into from Jul 2, 2015

Conversation

LukasReschke
Copy link
Member

While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)

@karlitschek I would love to have this in the 7.0.7 final

While making the AppStore ready for 8.1 I also deleted some dummy entries which means that these IDs do not resolve anymore. We should remove them to prevent errors such as #17307

Ref owncloud/activity#320 (comment)
@LukasReschke LukasReschke added this to the 7.0.7-current-maintenance milestone Jul 2, 2015
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@MorrisJobke
Copy link
Contributor

The log entries for 52 & 53 are still showing up:

{"app":"core","message":"Invalid OCS content returned for app 166053","level":4,"time":"2015-07-02T07:03:51+00:00"}
{"app":"core","message":"Invalid OCS content returned for app 166052","level":4,"time":"2015-07-02T07:03:52+00:00"}

I also restarted my PHP-FPM (to avoid caching issues).

@LukasReschke
Copy link
Member Author

Argh. We also store the OCS ID in the database… Don't get me started. Let me see if there is some magic to fix this…………………

@LukasReschke
Copy link
Member Author

See #17316 and the other backports with regard to this 🙊

@MorrisJobke
Copy link
Contributor

Together with #17319 this fixes the issue 👍

@ghost
Copy link

ghost commented Jul 2, 2015

🚀 Test PASSed.🚀
chuck

@nickvergessen
Copy link
Contributor

👍

@MorrisJobke
Copy link
Contributor

#17317 (comment)

MorrisJobke added a commit that referenced this pull request Jul 2, 2015
@MorrisJobke MorrisJobke merged commit d8f88aa into stable7 Jul 2, 2015
@MorrisJobke MorrisJobke deleted the stable7-remove-ocs-ids branch July 2, 2015 12:39
@karlitschek
Copy link
Contributor

backport is fine with me.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants