Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Codestyle #224

Merged
merged 2 commits into from
Feb 2, 2019
Merged

Codestyle #224

merged 2 commits into from
Feb 2, 2019

Conversation

hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented Dec 18, 2018

With this PR every commiter has the same codestyle out of the box (please see .idea additions), and so any future PR has hopefully less/no codestyle changes.
I applied codestyle to every file

Now codestyle is per project
image

@davigonz

@hannesa2
Copy link
Contributor Author

app needs same after merge owncloud/android#2076

@DeepDiver1975
Copy link
Member

test-client seems to no longer exist in master - the two gradle files have been removed from snyk

@davigonz davigonz added this to the 1.0 milestone Dec 19, 2018
@davigonz
Copy link
Contributor

Thanks @hannesa2 for this contribution, this is very useful to complete one of the tasks I defined in owncloud/android#2351.

Can you include an overview about the code style in the original post so that everyone knows it without analyzing the .idea file?

@hannesa2
Copy link
Contributor Author

I took one very similar to common, additionally forced brackets and extended line length (we all have modern laptops) and it fits for my 11" Mac Air too.
There are some Kotlin settings toll
I don't fight for the content/style and everyone can change it, if he knows it better (don't forget to reformat complete project). Important is, everyone has the same setting

Btw Android Studio has a bug (I will search for Google ticket), it will always try to change codestyle setting on initial open of project. Workaround is to

  1. un-set codestyle
  2. apply
  3. set codestyle
  4. apply

@hannesa2
Copy link
Contributor Author

hannesa2 commented Dec 19, 2018

arghhh rebase again #226 but git is smart to check previous renames

@hannesa2
Copy link
Contributor Author

This is the bug https://issuetracker.google.com/issues/78097962 please star it at the top left corner by push the star.

image

@davigonz
Copy link
Contributor

The code looks good to me @hannesa2 though I put above a couple of questions

@davigonz
Copy link
Contributor

davigonz commented Feb 1, 2019

Code approved, @jesmrec , think that checking whether the library project compiles properly and the new code style appears in Android studio preferences would be enough.

@hannesa2
Copy link
Contributor Author

hannesa2 commented Feb 1, 2019

"checking whether the library project compiles properly"
image

@hannesa2 hannesa2 mentioned this pull request Feb 2, 2019
@michaelstingl
Copy link
Contributor

Code approved, @jesmrec , think that checking whether the library project compiles properly and the new code style appears in Android studio preferences would be enough.

Works for me 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants