-
Notifications
You must be signed in to change notification settings - Fork 148
Conversation
app needs same after merge owncloud/android#2076 |
test-client seems to no longer exist in master - the two gradle files have been removed from snyk |
Thanks @hannesa2 for this contribution, this is very useful to complete one of the tasks I defined in owncloud/android#2351. Can you include an overview about the code style in the original post so that everyone knows it without analyzing the |
I took one very similar to common, additionally forced brackets and extended line length (we all have modern laptops) and it fits for my 11" Mac Air too. Btw Android Studio has a bug (I will search for Google ticket), it will always try to change codestyle setting on initial open of project. Workaround is to
|
arghhh rebase again #226 but git is smart to check previous renames |
This is the bug https://issuetracker.google.com/issues/78097962 please star it at the top left corner by push the star. |
The code looks good to me @hannesa2 though I put above a couple of questions |
Code approved, @jesmrec , think that checking whether the library project compiles properly and the new code style appears in Android studio preferences would be enough. |
Works for me 👍 |
With this PR every commiter has the same codestyle out of the box (please see
.idea
additions), and so any future PR has hopefully less/no codestyle changes.I applied codestyle to every file
Now codestyle is per project
@davigonz