remove redundant intercept of httpclient with httpmethod

[theScrabi]

Issue: #378
App: owncloud/android#3353

---

QA

Reports:

• (1) Redirections 301 remove redundant intercept of httpclient with httpmethod #427 (comment)

[abelgardep]

Some questions and suggestions here @theScrabi

[abelgardep]

Just a suggestion that could be out of scope from this PR.

We could create a new data class that receives the value and the TimeUnit and use it here. So we could replace 2 variables with just one, and we won't need nested ?.let to set the timeouts. Maybe a new issue to do this?

[abelgardep]

Now that they are not nullable, we can get rid of ?.let here, can't we?

Suggested change

	retryOnConnectionFailure?.let { retryOnConnectionFailure(it) }
	followRedirects?.let { followRedirects(it) }
	retryOnConnectionFailure(retryOnConnectionFailure)
	followRedirects(followRedirects)

[abelgardep]

LGTM

[jesmrec]

Let's QA a bit here...

[jesmrec]

(1)

Redirections 301 do not work in comparison with master branch. Check out with server ocis.owncloud.works that points (301) to ocis.ocis-traefik.latest.owncloud.works.

Second request is where difference rises:

master && fix/okhttp_singleton :

12:02:49 HTTPS GET ocis.owncloud.works /status.php -> 301. (Location in response headers) ✅
12:02:55 HTTPS GET ocis.ocis-traefik.latest.owncloud.works /signin/v1/identifier/_/authorize?redirect_uri=oc%3A%2F%2Fandroid.owncloud.com&client_id=e4rAs... -> 302 ✅

fix/remove_redundant_client_call:

12:13:30 HTTPS GET ocis.owncloud.works /status.php -> 301 (Location in response headers) ✅
12:13:31 HTTPS GET ocis.ocis-traefik.latest.owncloud.works / -> 200 returning an html format in payload ❌

showing the error message: Malformed server configuration

You can check also with ocis-a11y.owncloud.works that points to ocis.a11y.owncloud.works

This chart summarizes the results:

	ocis.owncloud.works	ocis-a11y.owncloud.works
master	✅	❌ Malformed server configuration
fix/okhttp_singleton	✅	❌ Malformed server configuration
fix/remove_redundant_client_call	❌ Malformed server configuration	❌ Malformed server configuration

[theScrabi]

Since the redirect got changed compleatly in favour of the ConnectionValidator, it may not make sense to fix this partially. We may need to do the checks @jesmrec did on that branch to.

[jesmrec]

Since the redirection fixes and the new behaviour is developed inside the ConnectionValidator scope, this branch and the singleton one should not be merged in order not to break the redirections, currently working in master. When ConnectionValidator goes on, then we can proceed with this.

Is this OK?

[jesmrec]

To resumen when https://github.com/owncloud/enterprise/issues/4201 is done and merged