Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos/Videos auto-sync stopped working #1795

Closed
miodzicho opened this issue Sep 3, 2016 · 65 comments
Closed

Photos/Videos auto-sync stopped working #1795

miodzicho opened this issue Sep 3, 2016 · 65 comments

Comments

@miodzicho
Copy link

miodzicho commented Sep 3, 2016

Actual behaviour

Photos/Videos auto-sync doesn't work anymore, last succesfull sync was 2 days ago.
Uploads list is empty, no files to sync. They are new photos/videos to sync.

Expected behaviour

Photos/Videos should be auto synced to SofortUpload directory on Owncloud server.

Steps to reproduce

  1. take photo/video
  2. photo/video should appear on Uploads list
  3. photo/video should be synced to directory on the server

Can this problem be reproduced with the official owncloud server?
(url: https://demo.owncloud.org, user: test, password: test)

Environment data

Android version: 6.0.1

Device model: HTC M10

Stock or customized system: stock

ownCloud app version: 2.1.1

ownCloud server version:

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here
@ghost
Copy link

ghost commented Sep 4, 2016

Also reported at IRC as well as at central: https://central.owncloud.org/t/adroid-6-0-1-client-intant-uploads-not-working/2152?u=realrancor

The user in IRC reported that using the "ocloud" client works again. That one seems to be a themed but quite outdated version 1.7.2 of the official app.

@rkarlsba
Copy link

rkarlsba commented Sep 4, 2016

For the record, I (that IRC user) just tried to uninstall and reinstall the client after removing the ocloud client and same results. Guess I'll stick to the ocloud client until this is fixed.

@admered1
Copy link

admered1 commented Sep 4, 2016

I'm seeing the same here.

owncloud android 2.1.1

HTC One M8 - Droid 6.0

It's not even getting as far as trying to upload, so server version not relevant.

This has been working fine for years.

@solve-salvesen
Copy link

I'm seeing the same. Galaxy S7 - Android 6.0.1. Have tried reinstalling client and also tride to switch from internal to sd and back without luck.

@davivel
Copy link
Contributor

davivel commented Sep 5, 2016

Hi, everybody.

The underlying implementation of instant uploads has changed to try to support more devices and camera apps, including Android 7.

As an undesired side effect, you need to access the app settings and select the location where your camera app stores the pictures and videos in a new option called "Camera folder". The default value corresponds to the default location for Google Camera app (and others), but might not be yours.

Please, try to set this folder and tell us if the pictures are still not captured.

@solve-salvesen
Copy link

Hello again. I have tried different settings, and also changing from SD to internal storage with no luck.

This screenshot shows the settings in owncloud:
screenshot_20160905-085936

This image was taken as a test:
20160905_073018
This screeshots shows the filepath:
screenshot_20160905-090040
This shows the folder in TC:
screenshot_20160905-090113

The images is not being uploaded instantly.

@davivel
Copy link
Contributor

davivel commented Sep 5, 2016

Thank you, @andykvakk . These pictures correspond to a configuration saving is SD card? What is your camera app?

@solve-salvesen
Copy link

solve-salvesen commented Sep 5, 2016

Yes, the images are stored on SD card (The samsung phone seems to map some internal memory as sd card, but the images shows up in /storage/3338-6339/DCIM/Camera.

I use the standard Samsung APP v. 5.0.88. I will also do at test on my wifes Nexus 5 as soon as possible.

@davivel
Copy link
Contributor

davivel commented Sep 5, 2016

Thanks a lot. I would expect no problem with Nexus 5, we tested with several of them, but any feedback is welcome.

Please, could you try also with some other camera app in your device? I could suggest Open Camera - it's free, open source, and you can find it both in Google Play Store, F-Droid and maybe other stores.

@solve-salvesen
Copy link

solve-salvesen commented Sep 5, 2016

Testet open camera, changed the storage folder to same setting, but still no luck. Nothing happens in Owncloud client.

Change to default settings in Open Camera and changed the folderpath in OC client, then it worked like it supposed to, the file got uploaded instantly. I wonder if this has something to do about the SD card folder. On my S7, the /sdcard is not the same as my SD card. I will test some more.

New test with both camera apps pointing into same location (internal sd, /sdcard/DCIM/Camera). Only the pictures from Open Camera gets uploaded.

If i change OpenCamera location to use my SDcard, /storage/3338-6339/DCIM/Camera the images is not uploaded instantly.

My wifes Nexus 5 works like it should.

@davivel
Copy link
Contributor

davivel commented Sep 5, 2016

In 'Open Camera', 'Settings' icon, 'More camera controls...', is the option 'Use Storage Access Framework' enabled? In that case, could you test with it disabled?

@solve-salvesen
Copy link

Yes, it was enabled. Disabled it, but was not able to change to /storage/3338-6339/DCIM/Camera so i used /storage/emulated/0/DCIM/Camera, then it works from OpenCamera but still not from Samsungs app (which i also changed to same folder). This is strange.

Now both camera apps store the images to same folder, but only images from OpenCamera gets uploaded.

@davivel
Copy link
Contributor

davivel commented Sep 5, 2016

OK, thanks. This is the second time we watch this effect, and I also could confirm it on a Nexus 5. Samsung camera probably is using Storage Access Framework all the time.

For some reason, files created with DocumentsContract.createDocument are not noticed by inotify and our new implementation doesn't detect them.

Definitely, we need to deal with this ASAP.

@solve-salvesen
Copy link

Ok. Do feel free to contact me if you want me to test more.

@johfeu
Copy link

johfeu commented Sep 5, 2016

likewise. I have the same thing on Xperia 6.0.1

@admered1
Copy link

admered1 commented Sep 5, 2016

David A. Velasco said: "As an undesired side effect, you need to access the app settings and select the location where your camera app stores the pictures and videos in a new option called "Camera folder". The default value corresponds to the default location for Google Camera app (and others), but might not be yours."

I have tried the various paths to get to the Camera folder, but none of them make any difference I'm afraid.

@rkarlsba
Copy link

rkarlsba commented Sep 5, 2016

I've also chosen to store images on the SD card (Sony Z3+ phone)

@rkarlsba
Copy link

rkarlsba commented Sep 5, 2016

I hope this is fixed soon (as in fixed, not asking users to do a bunch of workarounds). Older versions just worked without fiddling around with stuff. This is important owncloud to be easy to use for non-geeks.

@ghost
Copy link

ghost commented Sep 5, 2016

I'm having the same exact issues as andykvakk. No instant upload from my camera folder '/storage/FA8F-27EF/DCIM/Camera'. I'm using LG G5, Android 6.0.1, LG's "Camera" app 5.0.83.

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 6, 2016

Could you check the fix in branch instant_upload_combined_solution and give us feedback about? Thanks in advance.

cc @miodzicho @gnul @rkarlsba @johfeu

@solve-salvesen
Copy link

solve-salvesen commented Sep 6, 2016

I will gladly test, but i'm not sure how to get the fix on my phone. I have found the branch, but should there be an . apk file? I don't have sdk or other build tools for android.

@davivel
Copy link
Contributor

davivel commented Sep 6, 2016

No, @andykvakk , sorry. At the moment you need to know how to build the app from source code to test it.

@johfeu
Copy link

johfeu commented Sep 7, 2016

I was able to build android_2.1.1-debug.apk successfully, but it would not install :( any clue where to find install logs or how to figure out what went wrong?

@davivel
Copy link
Contributor

davivel commented Sep 7, 2016

@johfeu, if the official Android app is installed in the same device, you will not be able to install a client build by yourself due to security rules.

But don't uninstall your official app, please.

Given the interest in this feature, let me prepare an APK that you all can test.

@davivel
Copy link
Contributor

davivel commented Sep 7, 2016

Find a test APK in https://github.com/owncloud/android/blob/instant_upload_combined_solution/android_2.1.2-beta-debug.apk .

It can be installed in your device without uninstalling your current ownCloud app, will appear as another app, ownCloudTest. You will need to allow APKs from "Unknown sources" in your device settings to install it. Then, disable instant uploads in your regular ownCloud app and start ownCloudTest as usually to enter your account details, enable instant uploads and give it a try.

If instant uploads were working for you in version 2.1.0 you can ignore the "camera folder" option.

@jester-ro
Copy link

Unfortunately i can't pinpoint what exactly triggered this either, i have the same issue with the stock camera folder on a Samsung S7. The .apk provided earlier seems to work tough.

@NickyHeuperman
Copy link

The proposed fix works for me (Samsung Galaxy S6 EDGE, android 6, samsung camera)

@wobblywob
Copy link

wobblywob commented Sep 8, 2016

The provided APK fixed the issue for me. My problem was the same as most reported above:

  • default camera's photos were not detected neither on local storage nor on SD Card
  • Open Camera photos weren't detected with Storage Access Framework (local or SD)
  • Open Camera photos were detected with SAF disabled.

@ctrlbru
Copy link

ctrlbru commented Sep 8, 2016

I confirm the test apk fixes the issue on LG G3 with stock camera app on external sd folder. Photos and videos not synchronized in the meantime seem to remain not synchronized, I guess I'll have to upload them manually.

@kaffeeringe
Copy link

kaffeeringe commented Sep 9, 2016

Same problem on my OnePlus 2 with their version of Android 6.0.1

When I try to choose the camera folder, the app tells me, the folder is empty - like any other folder I choose.

The App seems not to see the pictures.

@davivel
Copy link
Contributor

davivel commented Sep 9, 2016

@ctrlbru , sorry, you are right, you will need to upload those pictures manually from the list of files.

@kaffeeringe , files are not listed in the 'Camera folder' option, only folders (we should improve that showing files as disabled elements). You should both files and folders from the uploader. Go to the list of files in the app, tap on the (+) button, then the top upload icon; that file browser shows files and folders.

@e-alfred
Copy link

e-alfred commented Sep 9, 2016

Same problem here, running version 2.1.1 of the client on a BQ M5 running Android 6.0.1. Nothing gets uploaded despite the right folder is set. For image/video backup from an Android phone, this is a pretty bad bug.

@amjiphone
Copy link

I have a Galaxy Note 5 that was experiencing this issue and the test .apk is working on my phone now with the default camera app. Android 6.0.1

@marchaase
Copy link

marchaase commented Sep 10, 2016

I have a Galazy Note 5 - Android 6.0.1. I use the default Samsung Camera app. My photos are not syncing with the Google Play app nor the Test .apk linked in this thread. I save my camera pics on the sdcard.

In both apps, if I try to manually upload a file from the location: /storage/emulated/0/DCIM/Camera it works fine, I can see pics and upload them.

When setting the InstaUpload settings, if I navigate back from the default directory, once I get down to /storage/ and click on emulated - it then lists there are no folders available in /storage/emulated. Also in the same dialog, when in the /storage directory, it lists the emualted directory's date as 12/31/2014 - which seems odd.

@janarzz
Copy link

janarzz commented Sep 11, 2016

Hey,
I have problem with owncloud app version 2.1.1
When i take a photo, then owncloud not upload my photo automaticly...
I marked owncloud settings upload my photo automaticly.
Photos location /storage/0123-4567/DCIM/Camera.
I use Samsung Galaxy S7 and android version 6.0.1

@hiliev
Copy link

hiliev commented Sep 11, 2016

The test APK restored automatic sync of photos stored to the internal memory on Xperia Z3 Compact with Android 6.0.1.

@janarzz
Copy link

janarzz commented Sep 12, 2016

Hey, when goming this fix in Google Play Store ?

@davivel
Copy link
Contributor

davivel commented Sep 12, 2016

Very soon. We'll release a hot-fix version ASAP. Stay tuned.

@davivel
Copy link
Contributor

davivel commented Sep 12, 2016

By the way, @janarzz , did you try the test APK? Did it work for you?

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 12, 2016

The validation is in this status:

@davivel
Copy link
Contributor

davivel commented Sep 12, 2016

@OlivierS1, @kaffeeringe, @marchaase, could you please try to get to the camera folder through the paths /sdcard/DCIM/ or /mnt/sdcard/DCIM, please? Android is making some black magic with paths, symbolic links and the good-old Environment.getExternalStorageDirectory() method.

@delumerlino
Copy link

The test app works fine with Huawei P8 Lite and Android 6.0 :)

@marchaase
Copy link

I am back on the playstore version.

If I use the + button to try to upload a file, I can see pictures in all 3
folders: /storage/emulated/0/DCIM/Camera, /sdcard/DCIM/Camera, and
/mnt/sdcard/DCIM. Using this add file navigator it starts in the emulated
directory, and when I go up a directory to /storage/emulated all file
listings and folders disappear even though I was just in 0 and seeing files
and folders.

When I use the instant upload directory chooser and the 2 new folders
requested. I can get to the folders fine, but in the folders I don't see
any pictures (not sure if existence of pictures is expected or not here).
When any of the 3 folders are selected, no pictures upload.

Let me know if you need any more info.

On Sep 12, 2016 7:45 AM, "David A. Velasco" notifications@github.com
wrote:

@OlivierS1 https://github.com/OlivierS1, @kaffeeringe
https://github.com/kaffeeringe, @marchaase
https://github.com/marchaase, could you please try to get to the camera
folder through the paths /sdcard/DCIM/ or /mnt/sdcard/DCIM, please?
Android is making some black magic with paths, symbolic links and the
good-old Environment.getExteralStoragePath() method.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1795 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIpqBlMT0DbLHWK596Nhd-jAw2D4tOPjks5qpWV9gaJpZM4J0XpH
.

@amjiphone
Copy link

amjiphone commented Sep 12, 2016

@marchaase With the test .APK file, set your folder path to /storage/emulated/0/DCIM/Camera then take a new picture after setting that folder path. We have the same phone and android version and it works just fine for me.

I am experiencing the folders not displaying properly in the app navigator when trying to choose a new camera folder as well. It seems once I hit /storage/emulated/ the folders in there do not display properly, even on the test .apk file. All other folders seem to display just fine.

As a test, I am using the Samsung default camera application. I set my camera folder to /storage/emulated/0/DCIM/Camera and to /sdcard/DCIM/Camera and all new pictures I take get uploaded correctly.

@OlivierS1
Copy link

I suspect Google update have changed folder permissions and ownerships causing this series of issues.

@janarzz
Copy link

janarzz commented Sep 12, 2016

Hey,
What is the right camera folder location Samsung Galaxy S7 ?

@davivel
Copy link
Contributor

davivel commented Sep 13, 2016

I suspect Google update have changed folder permissions and ownerships causing this series of issues.

Well, I'm not sure if was the Google update or was there before in Android 6, but the permissions of the folders are the key.

In any case, please, take this into account:

If instant uploads were working in your device with ownCloud Android app version 2.1.0, then you don't really need to care about the value of the 'Camera folder' option. That option is only required if you are using Android 7 or if instant uploads never worked for you before

I'll add an ugly clarification to the option. Since we'd like to get the uploads fixed really fast, we'll make a fast release just that way. We can care about a better UI in settings in subsequent releases.

@davivel davivel added this to the 2.1.2 milestone Sep 13, 2016
@davivel
Copy link
Contributor

davivel commented Sep 13, 2016

That should do it. Updated the test APK in https://github.com/owncloud/android/blob/instant_upload_combined_solution/android_2.1.2-beta-debug.apk just in case anybody is curious. Added better filtering to prevent duplicated uploads.

ETA for release: tomorrow.

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 13, 2016

The feature with the last APK seems to be OK. Anyway, all the feedback you can give us will be helpful. Thanks everybody for your contributions.

@ljep42
Copy link

ljep42 commented Sep 14, 2016

Thanks! I was having issues with Note 4 android 6.0.1 running oc 2.1.1 with the instant upload and the latest .apk worked.

https://github.com/owncloud/android/blob/instant_upload_combined_solution/android_2.1.2-beta-debug.apk

@davivel
Copy link
Contributor

davivel commented Sep 14, 2016

This is now merged and pushed to the Play Store, will be available as soon as Google processes the update, what usually takes not too much time.

Thank you everybody for your help testing this, has been fundamental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests