Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Prevent http traffic #4066

Closed
9 tasks done
jesmrec opened this issue Jun 13, 2023 · 3 comments · Fixed by #4110
Closed
9 tasks done

[FEATURE REQUEST] Prevent http traffic #4066

jesmrec opened this issue Jun 13, 2023 · 3 comments · Fixed by #4110

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jun 13, 2023

New branding option like enforce_secure_connection (boolean):

  • true : http traffic not allowed, just https
  • false: http traffic allowed

In case http is not allowed and URL under http is typed, a correct error will be shown like non-secured traffic not allowed

Only checked in login view, not dynamic (at least in first iteration)

Default value: false (traffic allowed in vanilla app)

Reference: https://github.com/owncloud/enterprise/issues/5769

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@jesmrec jesmrec added this to the 4.1 - Next milestone Jun 13, 2023
@michaelstingl
Copy link
Contributor

New branding option like prevent_http (boolean):

Better name enforce_https or enforce_ssl?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Jun 13, 2023

Better name enforce_https or enforce_ssl?

yes, sounds more positive

@jesmrec
Copy link
Collaborator Author

jesmrec commented Jun 13, 2023

Let's call it enforce_secure_connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants