Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Prevent http traffic #4110

Merged
merged 7 commits into from Aug 1, 2023
Merged

[FEATURE REQUEST] Prevent http traffic #4110

merged 7 commits into from Aug 1, 2023

Conversation

manuelplazaspalacio
Copy link
Contributor

@manuelplazaspalacio manuelplazaspalacio commented Jul 26, 2023 •
edited by jesmrec

Related Issues

App: #4066

Library PR (if needed):

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

#4110 (comment)

@manuelplazaspalacio manuelplazaspalacio self-assigned this Jul 26, 2023
@manuelplazaspalacio manuelplazaspalacio linked an issue Jul 27, 2023 that may be closed by this pull request
[FEATURE REQUEST] Prevent http traffic #4066
Closed
9 tasks
jabarros
jabarros approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jabarros jabarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec jesmrec self-requested a review July 27, 2023 10:00
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 27, 2023

This is how the new error looks like. Is it OK @michaelstingl ?

Screenshot 2023-07-27 at 12 33 55

@michaelstingl
Copy link
Contributor

Works for me 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 27, 2023 •
edited

QA

  1. New accounts
enforce_secure_connection = true enforce_secure_connection = false
http server Not allowed ✅ Allowed ✅
https non-secured Allowed ✅ Allowed ✅
https secured Allowed ✅ Allowed ✅
  1. Migration with enforce_secure_connection = true
  • https secure
  • https non-secure
  • http -> NO MIGRATION. Just for new accounts

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 31, 2023

Ready to go!!

@manuelplazaspalacio manuelplazaspalacio merged commit 2ed01a9 into master Aug 1, 2023
3 checks passed
@manuelplazaspalacio manuelplazaspalacio deleted the feature/prevent_http_traffic branch August 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabarros jabarros jabarros approved these changes

@jesmrec jesmrec jesmrec approved these changes

Assignees

@manuelplazaspalacio manuelplazaspalacio

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Prevent http traffic
4 participants
@manuelplazaspalacio @jesmrec @michaelstingl @jabarros