Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure account for instant upload #1637

Closed
wants to merge 1 commit into from
Closed

configure account for instant upload #1637

wants to merge 1 commit into from

Conversation

LukeOwlclaw
Copy link

@LukeOwlclaw LukeOwlclaw commented Apr 26, 2016

As discussed in #827, instant uploads should always use the same account (rather than the currently active one).

edited by @jabarros

  • Create 'instant_upload_multi_account' branch from master in android repository @jabarros
  • Merge 'instant_upload_multi_account' branch into master
  • Download LukeOwncloud:instant_upload_multi_account branch changes @jabarros (WIP)
  • Create test plan @jesmrec
  • Validate test plan @jesmrec

accountName);
return account;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to add these new methods to AccountUtils class, dont you think?

@malkomich
Copy link
Member

I guess a new setting options is needed in order to set the account chosen for the instant uploads, because currently the destination account keeps changing when you change the active one.

@davivel
Copy link
Contributor

davivel commented Jul 13, 2016

Hi, @LukeOwncloud. I made a fast test, and there is an important problem here. If the user enables the instant upload and doesn't change the default folder, no account is saved as target account and the upload is not done. The broadcast receiver logs:

07-13 11:07:55.544 14302-14302/com.owncloud.android W/com.owncloud.android.files.InstantUploadBroadcastReceiver: No account found for instant upload, aborting

Could you have a look to it?

@davivel davivel added this to the 2.2.0 milestone Jul 14, 2016
@danimo
Copy link
Contributor

danimo commented Jul 18, 2016

@LukeOwncloud hey, any chance you can take a look at this again? This is really a nice fix in general.

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 22, 2016

I agree with the comments of @malkomich and @davivel. It is not much intuitive to switch the default account until the user selects one.

Thinking in posible options to select a default account for the instant uploads:

  1. In the Upload Pathsection, showing a pop-up to select the account to instantly upload to. After that, browsing in that account to select the folder. The advantage is: possibility of selecting different accounts for photos and videos and ease to use. The problem in this case is the upgrade from previous version. Which user account should be the default from scratch if the user had the instant uploads enabled?

  2. In the below section of instant uploads, where the Camera folder and the Copy-Move options are placed, set another option to select the default account. This one has the advantage of giving users backwards compatibility: by not selecting any account, the behaviour is uploading to the current one, as right now is performed. By default the account is empty, so that upgrade from previous version is easier.

What do you think? more possibilities?

cc @jabarros @davivel @malkomich @rperezb @owncloud/android-developers

@davivel
Copy link
Contributor

davivel commented Sep 27, 2016

@jesmrec , I just pushed a work-in-progress branch with something similar to your option 2) . It's done from the recent changes to update instant uploads for Android 7, in branch https://github.com/owncloud/android/tree/instant_upload_set_account .

Let's move the focus there, since @LukeOwncloud seems not available for this anymore.

Thanks

@davivel davivel closed this Sep 27, 2016
@LukeOwlclaw
Copy link
Author

I am sorry, guys! Indeed I am not available these days. But I truly hope I will be eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants