-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure account for instant upload #1637
configure account for instant upload #1637
Conversation
accountName); | ||
return account; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to add these new methods to AccountUtils
class, dont you think?
I guess a new setting options is needed in order to set the account chosen for the instant uploads, because currently the destination account keeps changing when you change the active one. |
Hi, @LukeOwncloud. I made a fast test, and there is an important problem here. If the user enables the instant upload and doesn't change the default folder, no account is saved as target account and the upload is not done. The broadcast receiver logs:
Could you have a look to it? |
@LukeOwncloud hey, any chance you can take a look at this again? This is really a nice fix in general. |
I agree with the comments of @malkomich and @davivel. It is not much intuitive to switch the default account until the user selects one. Thinking in posible options to select a default account for the instant uploads:
What do you think? more possibilities? cc @jabarros @davivel @malkomich @rperezb @owncloud/android-developers |
@jesmrec , I just pushed a work-in-progress branch with something similar to your option 2) . It's done from the recent changes to update instant uploads for Android 7, in branch https://github.com/owncloud/android/tree/instant_upload_set_account . Let's move the focus there, since @LukeOwncloud seems not available for this anymore. Thanks |
I am sorry, guys! Indeed I am not available these days. But I truly hope I will be eventually. |
As discussed in #827, instant uploads should always use the same account (rather than the currently active one).
edited by @jabarros