New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Android Sharesheet #2968
Conversation
val excludeLists = ArrayList<ComponentName>() | ||
if (resInfo.isNotEmpty()) { | ||
for (info in resInfo) { | ||
val activityInfo = info.activityInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this block can be put into a function:
getExcludeListForInfo(info: ResolveInfo, packagesToExcloude: Array<String>) : ArrayList<ComponentName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM
d31c8b1
to
f834a79
Compare
Yes, you are right, i have added a title according to https://developer.android.com/training/sharing/send#adding-rich-content-previews |
(2) [FIXED]Just to keep compatibility and same wording as previous version, when the link is shared the proper string is |
(3) [DONE]
Current: In the menu, we can see is this feasible? |
Ok, updated.
Im not sure why it changes 🤔 |
908a7bb
to
9849dc3
Compare
(3) affected only Android 7, since newer versions use their own wording "Share" PR Approved on my side, everything fixed Thanks also @ddopik for your contribution!! |
Implements #2902 partially.
We cannot exclude oC from sharing targets till API 24, so we'll keep the previous behaviour for API <24, and use sharesheet for newer ones.
Old code will be removed when we upgrade min_sdk_version to api 24.
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.16/2922-new_share_sheet.md
Bugs & improvements:
Send
menu [Feature] Android Sharesheet #2968 (comment)