[New arch] Use moshi to parse sharees #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
theScrabi
requested review from
davigonz and
abelgardep
and removed request for
davigonz
theScrabi
force-pushed
the
new_arch/moshi_parse_sharees
branch
from
6a124dd
to
e10faa9
Compare
6 tasks
abelgardep
requested changes
Oct 16, 2020
...main/java/com/owncloud/android/data/sharing/sharees/datasources/mapper/RemoteShareeMapper.kt
Show resolved
Hide resolved
...main/java/com/owncloud/android/data/sharing/sharees/datasources/mapper/RemoteShareeMapper.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/data/shares/datasources/OCRemoteShareesDataSourceTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/data/shares/datasources/OCRemoteShareesDataSourceTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/data/shares/datasources/OCRemoteShareesDataSourceTest.kt
Outdated
Show resolved
Hide resolved
...udDomain/src/main/java/com/owncloud/android/domain/sharing/sharees/GetShareesAsyncUseCase.kt
Outdated
Show resolved
Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/sharing/sharees/model/OCSharee.kt
Outdated
Show resolved
Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/sharing/shares/model/OCShare.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/data/shares/datasources/OCRemoteShareesDataSourceTest.kt
Outdated
Show resolved
Hide resolved
theScrabi
force-pushed
the
new_arch/moshi_parse_sharees
branch
from
3e4a5a2
to
a94a00d
Compare
abelgardep
approved these changes
Oct 20, 2020
theScrabi
force-pushed
the
new_arch/moshi_parse_sharees
branch
from
71090b7
to
f3e3982
Compare
|
Approved an my side |
abelgardep
force-pushed
the
new_arch/moshi_parse_sharees
branch
from
f3e3982
to
1710aa1
Compare
abelgardep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related Issue: #2704
related lib pr: owncloud/android-library#352
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.16/2994-sharees_moshi.md