Add Webfinger support #3632
Merged
Add Webfinger support #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theScrabi
force-pushed
the
feature/webfinger
branch
2 times, most recently
from
78ec71e
to
a65c31c
Compare
abelgardep
changed the title
9 tasks
abelgardep
force-pushed
the
feature/webfinger
branch
3 times, most recently
from
693c19d
to
7e7e2e5
Compare
JuancaG05
requested changes
Oct 13, 2022
There was a problem hiding this comment.
Just some tiny suggestions, great work boys! @abelgardep @theScrabi
owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/utils/MdmConfigurations.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/webfinger/OCWebfingerRepository.kt
Show resolved
Hide resolved
JuancaG05
approved these changes
Oct 13, 2022
(1)
Current: Request sent / URL resolved without username |
JuancaG05
force-pushed
the
feature/webfinger
branch
from
c391aa9
to
8d12952
Compare
|
Nice improvements in the auth flow. Just a tiny one: In order to align clients, could it be posible to change the |
|
Button tag changed from |
|
Done and approved from my side. |
jesmrec
force-pushed
the
feature/webfinger
branch
from
d8017f9
to
059b4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3759
Library: owncloud/android-library#481
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_3.0/Webfinger.md
Reports:
ProceedAdd Webfinger support #3632 (comment) [DONE]