Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share a folder from inside the folder #3659

Merged
merged 5 commits into from May 30, 2022
Merged

Conversation

davcres
Copy link
Contributor

@davcres davcres commented May 5, 2022

Related Issues

App: #1441

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.21/3659-Share%20folder%20from%20inside.md

@davcres davcres requested review from abelgardep and fesave May 5, 2022 12:35
@davcres davcres linked an issue May 5, 2022 that may be closed by this pull request
@davcres davcres self-assigned this May 5, 2022
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented May 16, 2022

(1) [FIXED]

  1. Open an external app (Gallery, Photos...)
  2. Select a file and share with oC

Current: folder picker shows the share icon on the top bar. By clicking, nothing happens
Expected: folder picker should not show the share icon on the top bar

Pixel 5 v12
611970ac

@jesmrec
Copy link
Collaborator

jesmrec commented May 16, 2022

(2) [FIXED]

Following (1), the share icon also is displayed when:

  • Select a path in the Auto uploads
  • Select a target folder in the copy/move actions

In both cases, the share operation works fine and the folder is correctly shared.

The question here... should we keep it? such operations do not have nothing to do with sharing.

My personal opinion: Remove the icon from there.

@davcres
Copy link
Contributor Author

davcres commented May 19, 2022

(2)

Following (1), the share icon also is displayed when:

  • Select a path in the Auto uploads
  • Select a target folder in the copy/move actions

In both cases, the share operation works fine and the folder is correctly shared.

The question here... should we keep it? such operations do not have nothing to do with sharing.

My personal opinion: Remove the icon from there.

Done

@davcres
Copy link
Contributor Author

davcres commented May 19, 2022

Done

@jesmrec
Copy link
Collaborator

jesmrec commented May 24, 2022

Everything fixed

approved

@abelgardep abelgardep force-pushed the feature/share-current-folder branch from 32c8929 to 35e47ec Compare May 27, 2022 06:31
@abelgardep abelgardep merged commit 21a8d0c into master May 30, 2022
@abelgardep abelgardep deleted the feature/share-current-folder branch May 30, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't share the current folder
4 participants