Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Adapt empty views depending on file list option #3728

Merged
merged 11 commits into from
Sep 2, 2022
Merged

[New arch] Adapt empty views depending on file list option #3728

merged 11 commits into from
Sep 2, 2022

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Aug 16, 2022 •
edited

Related Issues

App: #3026

Title and subtitle aligned with oc10

  • Available offline icon should be added as svg. It's a png atm.
All files Available offline Shared by link Uploads Logs
empty_files empty_offline empty_shared empty_uploads empty_logs

QA

@abelgardep abelgardep self-assigned this Aug 16, 2022
@abelgardep abelgardep linked an issue Aug 16, 2022 that may be closed by this pull request
[FEATURE REQUEST] Improve empty views #3026
Closed
13 tasks
@abelgardep abelgardep force-pushed the new_arch/local_removal_no_connection branch from 63cfd94 to fa9c0f1 Compare August 18, 2022 08:52
Base automatically changed from new_arch/local_removal_no_connection to new_arch/synchronization August 18, 2022 10:15
@abelgardep abelgardep force-pushed the new_arch/empty_views branch 2 times, most recently from ff7e0bd to 62697fa Compare August 22, 2022 11:48
@abelgardep abelgardep marked this pull request as ready for review August 31, 2022 15:02
JuancaG05
JuancaG05 requested changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice visual change @abelgardep 👍! Just some tiny suggestions and we are ready to go

owncloudApp/src/main/res/layout/item_empty_dataset.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
JuancaG05
JuancaG05 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to QA! 💯

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 1, 2022 •
edited

QA checks

  • File list
  • Av offline
  • Share by link
  • Uploads
  • Logs
  • Share external

Let's go on with the first iteration.

@abelgardep abelgardep merged commit 8c92475 into new_arch/synchronization Sep 2, 2022
@abelgardep abelgardep deleted the new_arch/empty_views branch September 2, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Improve empty views
3 participants
@abelgardep @jesmrec @JuancaG05