Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Add link to drawer menu #3949

Merged
merged 7 commits into from
Mar 8, 2023
Merged

[FEATURE REQUEST] Add link to drawer menu #3949

merged 7 commits into from
Mar 8, 2023

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Mar 2, 2023 •
edited

Related Issues

App: #3907

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this Mar 2, 2023
@JuancaG05 JuancaG05 linked an issue Mar 2, 2023 that may be closed by this pull request
[FEATURE REQUEST] Add link to drawer menu #3907
Closed
10 tasks
abelgardep
abelgardep requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @JuancaG05

owncloudApp/src/main/res/values/setup.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/nav_drawer_footer.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/nav_drawer_footer.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/nav_drawer_footer.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/nav_drawer_footer.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt Outdated Show resolved Hide resolved
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 7, 2023 •
edited

QA checks

use_drawer_logo = true

drawer_link_label empty drawer_link_label not empty
drawer_link empty big logo ✅ big logo ✅
drawer_link not empty big logo ✅ logo + text + link ✅

use_drawer_logo = false

drawer_link_label empty drawer_link_label not empty
drawer_link empty blank ✅ blank ✅
drawer_link not empty blank ✅ blank ✅

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 7, 2023

About this scenario:

<bool name="use_drawer_logo">false</bool>
<string name="drawer_link_label">owncloud</string>
<string name="drawer_link">https://owncloud.com</string>

Current: text and link are available together with the logo

Expected: not visible. use_drawer_logo = false means that there is no logo (ownBrander logic). This is posible in the vanilla app, but in the oB.

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 7, 2023

Problem with logo = false fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 7, 2023

Approved on my side.

Will need oB spec

@abelgardep abelgardep added this pull request to the merge queue Mar 7, 2023
@abelgardep abelgardep removed this pull request from the merge queue due to a manual request Mar 7, 2023
@abelgardep abelgardep added this pull request to the merge queue Mar 7, 2023
@abelgardep abelgardep removed this pull request from the merge queue due to a manual request Mar 7, 2023
@abelgardep abelgardep merged commit 1468850 into spaces/main Mar 8, 2023
@abelgardep abelgardep deleted the feature/drawer_link branch March 8, 2023 11:30
@JuancaG05 JuancaG05 mentioned this pull request Mar 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add link to drawer menu
3 participants
@JuancaG05 @jesmrec @abelgardep