Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accept language header to all requests #3982

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Mar 21, 2023

Related Issues

App: #3980

Library PR (if needed): owncloud/android-library#551

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 linked an issue Mar 22, 2023 that may be closed by this pull request
9 tasks
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 22, 2023

With the attached fix, Accept-Language is always included by using the most generic variant of the language. That means:

Accept-Language: en
Accept-Language: es
Accept-Language: de

There is no es-ES or en-US or de-DE . Requirements are fullfiled, so it's valid.

OK from my side.

@michaelstingl
Copy link
Contributor

Accept-Language: en
Accept-Language: es
Accept-Language: de

There is no es-ES or en-US or de-DE . Requirements are fullfiled, so it's valid.

Same in web implementation ✅

@abelgardep abelgardep merged commit d556c2f into master Mar 24, 2023
@abelgardep abelgardep deleted the feature/add_language_header branch March 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Always send a language header in all requests
4 participants