Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to the authentication flow #4011

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Add prompt to the authentication flow #4011

merged 3 commits into from
Apr 13, 2023

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Apr 10, 2023

Related Issues

App: #3862

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@abelgardep abelgardep linked an issue Apr 12, 2023 that may be closed by this pull request
9 tasks
@abelgardep abelgardep marked this pull request as ready for review April 12, 2023 06:54
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 12, 2023

QA

Connection:

  • demo.owncloud.com
  • ocis.owncloud.works
  • OAuth2 server

Branding

  • No values in prompt
  • Values in prompt

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 12, 2023

In case the prompt field is empty (by branding), prompt is sent in the request anyway. Should we prevent this?

@michaelstingl
Copy link
Contributor

In case the prompt field is empty (by branding), prompt is sent in the request anyway. Should we prevent this?

I’d think, empty should fallback to default. I’m not aware of use cases with empty prompts.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 13, 2023

Ok, in the vanilla app, the default case (select account) is the only available case. Fallback to default will be managed in oB issue.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 13, 2023

Approved in app level. Will create a branding issue fue this.

@abelgardep abelgardep merged commit 43dbdcb into master Apr 13, 2023
2 checks passed
@abelgardep abelgardep deleted the improvement/prompt branch April 13, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add prompt to authorize request
4 participants