[FIX] Spaces' thumbnails not loaded the first time #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
from
39cb720
to
c96d7f1
Compare
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
from
efeef44
to
da945ca
Compare
JuancaG05
changed the title
JuancaG05
requested changes
Jun 23, 2023
owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/FileListAdapter.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/FileListAdapter.kt
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListFragment.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/thumbnails/ThumbnailsRequester.kt
Show resolved
Hide resolved
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
2 times, most recently
from
9b10d01
to
4beaef6
Compare
JuancaG05
approved these changes
Jun 27, 2023
(1) [FIXED]thumbnails' shape has changed, is this intended @manuelplazaspalacio?
|
(2) [FIXED]Check the following steps out:
Current: Thumbnail not updated. If the image would be downloaded, thumbnail would have updated. Pixel 2 Android 11 |
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
from
631d893
to
86ad085
Compare
- Solving loading images errors.
- Adding name to modified files
Solving lint errors
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
from
5c6e03d
to
885ed79
Compare
manuelplazaspalacio
force-pushed
the
feature/thumbnails_not_loaded_first_time
branch
from
f271deb
to
f31526a
Compare
|
This is approved on my side. Work to do: apply changes to uploads view to make these changes visible there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #3959
Spaces
Files list
Library PR (if needed):
QA
Reports and suggestions